Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix heading levels for DOCX & HTML #184

Merged
merged 1 commit into from
Oct 28, 2024
Merged

fix: fix heading levels for DOCX & HTML #184

merged 1 commit into from
Oct 28, 2024

Conversation

vagenas
Copy link
Contributor

@vagenas vagenas commented Oct 28, 2024

  • HTML backend:
    • used add_heading instead of add_text for headings
    • did minor refactoring
  • DOCX backend:
    • passed actual level to add_heading (explicitly setting it to 1 if not identifiable)
    • did minor refactoring

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the
    conventional commits.
  • Documentation has been updated, if necessary.
  • Examples have been added, if necessary.
  • Tests have been added, if necessary.

@vagenas vagenas merged commit b9f5c74 into main Oct 28, 2024
7 checks passed
@vagenas vagenas deleted the fix-header-levels branch October 28, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dolfim-ibm dolfim-ibm dolfim-ibm approved these changes

@PeterStaar-IBM PeterStaar-IBM PeterStaar-IBM approved these changes

@staar staar Awaiting requested review from staar

@cau-git cau-git Awaiting requested review from cau-git

@maxmnemonic maxmnemonic Awaiting requested review from maxmnemonic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vagenas @PeterStaar-IBM @dolfim-ibm