From 98f7f1e2f8dd7e5770146010e6b61c4ff8eaf33a Mon Sep 17 00:00:00 2001 From: David Marchand Date: Mon, 27 Jan 2025 11:53:47 +0100 Subject: [PATCH] net/mlx5: fix leak in HWS flow counter action This was caught by our internal covscan. mp_name can be leaked in case of errors. Fixes: 4d368e1da3a4 ("net/mlx5: support flow counter action for HWS") Cc: stable@dpdk.org Signed-off-by: David Marchand --- drivers/net/mlx5/mlx5_hws_cnt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_hws_cnt.c b/drivers/net/mlx5/mlx5_hws_cnt.c index 0197c098f64..eaceedd5ba5 100644 --- a/drivers/net/mlx5/mlx5_hws_cnt.c +++ b/drivers/net/mlx5/mlx5_hws_cnt.c @@ -723,7 +723,7 @@ mlx5_hws_cnt_pool_create(struct rte_eth_dev *dev, if (priv->sh->cnt_svc == NULL) { ret = mlx5_hws_cnt_svc_init(priv->sh, error); if (ret) - return ret; + goto error; } cparam.fetch_sz = HWS_CNT_CACHE_FETCH_DEFAULT; cparam.preload_sz = HWS_CNT_CACHE_PRELOAD_DEFAULT; @@ -767,6 +767,7 @@ mlx5_hws_cnt_pool_create(struct rte_eth_dev *dev, MLX5_ASSERT(ret); mlx5_hws_cnt_pool_destroy(priv->sh, cpool); priv->hws_cpool = NULL; + mlx5_free(mp_name); return ret; }