Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISIS Build Excessive Warnings #5241

Closed
acpaquette opened this issue Jul 18, 2023 · 0 comments · Fixed by #5257
Closed

ISIS Build Excessive Warnings #5241

acpaquette opened this issue Jul 18, 2023 · 0 comments · Fixed by #5257
Assignees
Labels
bug Something isn't working build Issue related to building ISIS

Comments

@acpaquette
Copy link
Collaborator

ISIS version(s) affected: dev

Description
When building ISIS using C++ 11 and greater, ISIS produces an excessive amount of warnings due to linking against process objects that use binary_function and unary_function

These two class definitions have been deprecated in C++ 11 and removed as of C++ 17. This will be a problem in the future and squashing them sooner rather than later would be ideal.

How to reproduce
Follow the ISIS build instructions using C++ 11 or greater

Possible Solution
There are some replacements for this but none stand out to me as an easy, just replace binary_function and unary_function with some new thing. It seems like std::bind might be the easiest replacement but result in some refactoring in the ISIS process classes and various functr uses.

@acpaquette acpaquette added bug Something isn't working build Issue related to building ISIS labels Jul 18, 2023
@amystamile-usgs amystamile-usgs self-assigned this Aug 7, 2023
@acpaquette acpaquette mentioned this issue Aug 25, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build Issue related to building ISIS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants