Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially including rclone with the conda distribution #5098

Closed
oleg-alexandrov opened this issue Dec 30, 2022 · 2 comments
Closed

Potentially including rclone with the conda distribution #5098

oleg-alexandrov opened this issue Dec 30, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@oleg-alexandrov
Copy link
Contributor

ISIS needs its data to be able to function. Recently a tool named downloadIsisData is included, which is the only way to get the data. This tool fails saying that 'rclone' is missing.

Since this program is pretty much a required dependency, I would think having it installed and shipped with ISIS would likely make sense. The user can install it separately, of course, but conda is slow to use and takes a while to fetch, and looks like it should be simpler to just have it fetched with the rest of the package.

@oleg-alexandrov oleg-alexandrov added the bug Something isn't working label Dec 30, 2022
@Kelvinrr
Copy link
Collaborator

Kelvinrr commented Jan 3, 2023

I think this makes sense. I think the scripts are kinda treated as second class so at the time wasn't sure whether or not to include it as a dep and increase the ISIS deps. PR #5091 basically does this so we should also add rclone.

@antonhibl
Copy link
Contributor

@Kelvinrr I believe this has been addressed as environment.yml now requires rclone, just checked out dev to double check.

@Kelvinrr Kelvinrr closed this as completed May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants