Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

photrim - needs an option to use the shapemodel or not when trimming inc and ema #2230

Closed
ascbot opened this issue Feb 14, 2019 · 2 comments
Closed
Labels
enhancement New feature or request

Comments

@ascbot
Copy link
Contributor

ascbot commented Feb 14, 2019


Author Name: Tammy Becker (Tammy Becker)

Original Assignee: Marjorie Hahn


photrim needs the equivalent of the 'usedem' option available in photomet.

photrim currently trims at the 'local' emission and incidence angle when an image points to a shapemodel in the Kernels group.

The results can be messy and irregular with the shapemodel. The option to turn off reference to the shapemodel and use
the ellipsoid emission/incidence angle value results in a smooth boundary (usedem=false).

An undesirable work around is to use editlab and set shapemode=NULL; this is not good.

@ascbot ascbot added this to the 3.5.0 (FY17 2017-01-25 Jan) milestone Feb 14, 2019
@ascbot ascbot added the enhancement New feature or request label Feb 14, 2019
@ascbot
Copy link
Contributor Author

ascbot commented Feb 14, 2019


Original Redmine Comment
Author Name: Marjorie Hahn (Marjorie Hahn)
Original Date: 2016-08-01T23:29:23Z


The application, photrim, with the option to use DEM can be found ready for testing in /work/projects/isis/latest/m04181

@ascbot
Copy link
Contributor Author

ascbot commented Feb 14, 2019


Original Redmine Comment
Author Name: Tammy Becker (Tammy Becker)
Original Date: 2016-10-31T18:26:32Z


photrim works as expected now. The documentation has also been improved in terms of how the usedem works and the source of angles when trimming.

UserTestPlan Location = /work/projects/usertests/UserTestPlans/Apps/photrim/m04181

Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant