Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spdm_responder_emu/spdm_requester_emu fails if transport NONE is selected. #358

Open
arugan02 opened this issue Jul 28, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@arugan02
Copy link

$ ./spdm_responder_emu --trans NONE
spdm_responder_emu version 0.1
trans - 0x0
context_size - 0x3048
max_spdm_msg_size (4608) must be greater than or equal to data_transfer_size (4736).

I believe the issue is due to macro LIBSPDM_SENDER_BUFFER_SIZE, LIBSPDM_RECEIVER_BUFFER_SIZE appending LIBSPDM_TRANSPORT_ADDITIONAL_SIZE. The transport header_size, tail_size is set during runtime based on the selected transport. For transport NONE these values are 0. But these macros LIBSPDM_SENDER_BUFFER_SIZE and LIBSPDM_RECEIVER_BUFFER_SIZE add LIBSPDM_TRANSPORT_ADDITIONAL_SIZE. I have a possible fix, shall raise a PR and we can discuss other options in code review. Please ack. Thanks.

@steven-bellock steven-bellock added the bug Something isn't working label Jul 29, 2024
@steven-bellock
Copy link
Contributor

@arugan02 that seems reasonable. We'll review the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants