Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compile options to libspdm_gen_x509_csr #2825

Open
rw8896 opened this issue Sep 4, 2024 · 2 comments
Open

Add compile options to libspdm_gen_x509_csr #2825

rw8896 opened this issue Sep 4, 2024 · 2 comments

Comments

@rw8896
Copy link
Contributor

rw8896 commented Sep 4, 2024

bool libspdm_gen_x509_csr(size_t hash_nid, size_t asym_nid,

bool libspdm_gen_x509_csr(size_t hash_nid, size_t asym_nid,

The implementation could use LIBSPDM_ENABLE_CAPABILITY_CSR_CAP to wrap the whole function.
And it should add crypto options (e.g. LIBSPDM_RSA_SSA_2048_SUPPORT) to wrap around the crypto operation code.

@steven-bellock
Copy link
Contributor

@rw8896 is this to save on code size?

@rw8896
Copy link
Contributor Author

rw8896 commented Sep 9, 2024

Not really. It caused compiler errors as RSA was not enabled in my mbedtls configuration.

After looking into this function further, I think it doesn't allow the caller to specify the pathLen in basic constraints.
If that's the case, maybe pathLen should be added as a input to make this API more general?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants