Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OnboardingServiceImpl needs to implement SignatureService #147

Open
oliverrahner opened this issue Feb 26, 2021 · 0 comments
Open

OnboardingServiceImpl needs to implement SignatureService #147

oliverrahner opened this issue Feb 26, 2021 · 0 comments
Assignees
@saschadoemer

Comments

@oliverrahner
Copy link
Member

Describe the bug
When the SignatureService interface was created, necessary refactoring for com.dke.data.agrirouter.impl.onboard.secured.OnboardServiceImpl had not been done.
This leads to duplicate code:
https://github.com/DKE-Data/agrirouter-api-java/blob/develop/agrirouter-api-java-impl/src/main/java/com/dke/data/agrirouter/impl/onboard/secured/OnboardingServiceImpl.java#L117-L160

Expected behavior
Code respects DRY, OnboardServiceImpl implements SignatureService
@oliverrahner oliverrahner changed the title OnboardServiceImpl needs to implement SignatureService OnboardingServiceImpl needs to implement SignatureService Feb 26, 2021
@saschadoemer saschadoemer self-assigned this Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saschadoemer saschadoemer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@saschadoemer @oliverrahner