Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we remove the SecurityLogging ? #4365

Closed
chaen opened this issue Dec 11, 2019 · 5 comments
Closed

Should we remove the SecurityLogging ? #4365

chaen opened this issue Dec 11, 2019 · 5 comments
Assignees

Comments

@chaen
Copy link
Contributor

chaen commented Dec 11, 2019

Similarly to the system logging, the security logging is made obsolete by the centralized logging.

This line in the security logging file

2019-12-11 14:36:26.063077, True, ::ffff:134.158.49.148, 38930, [fstagni:lhcb_mcproc](/DC=ch/DC=cern/OU=Organic Units/OU=Users/CN=fstagni/CN=693025/CN=Federico Stagni), lbvobox102.cern.ch, 9166, Accounting/DataStoreHelper, RPC/commitRegisters

appears in the centralized logging as such

{
  "_index": "lhcb-dirac-logs-accounting-datastorehelper-2019.12.11",
  "_type": "doc",
  "_id": "-g5j9W4Bkahmagh1xKRD",
  "_version": 1,
  "_score": null,
  "_source": {
    "hostname": "lbvobox102.cern.ch",
    "varmessage": "([::ffff:134.158.49.148]:38930)[lhcb_mcproc:fstagni] RPC/commitRegisters(<masked>)",
    "levelname": "NOTICE",
    "exc_info": "",
    "@timestamp": "2019-12-11T14:36:26.000Z",
    "customname": "",
    "componentname": "Accounting/DataStoreHelper",
    "componentindex": "accounting-datastorehelper",
    "message": "Executing action",
    "spacer": " ",
    "asctime": "2019-12-11 14:36:26",
    "@version": "1",
    "type": "stomp"
  },
  "fields": {
    "@timestamp": [
      "2019-12-11T14:36:26.000Z"
    ]
  },
  "sort": [
    1576074986000
  ]
}

So, should we remove it along with the System Logging ?

@atsareg
Copy link
Contributor

atsareg commented Dec 11, 2019

Security logging should be kept for a certain while according to legal requirements. This was never explicitly requested so far, but should be checked if anybody is asking for this info to be stored for a certain period (6 or 12 months or ...)

@chaen
Copy link
Contributor Author

chaen commented Dec 11, 2019

we can keep the data, but we could remove the service

@fstagni fstagni self-assigned this Aug 17, 2021
@fstagni fstagni added this to the v8.0 milestone Aug 17, 2021
@fstagni
Copy link
Contributor

fstagni commented Feb 16, 2022

Flag added in #5760. Should

  • check for instructions once more
  • remove the service in a later stage

@fstagni fstagni modified the milestones: v8.0, v8.1 Feb 16, 2022
@fstagni
Copy link
Contributor

fstagni commented Nov 17, 2022

#6561 swaps the default flag.
Service will be removed from 8.2

@fstagni fstagni modified the milestones: v8.1, v8.2 Nov 17, 2022
@fstagni fstagni removed this from the v8.2 milestone Oct 26, 2023
@fstagni
Copy link
Contributor

fstagni commented Oct 26, 2023

There won't be any 8.2, and the SecurityLogging service won't be added to diracx. Enough to close this issue.

@fstagni fstagni closed this as completed Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants