Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code correction in the file 'hid-uclogic-params.c' #658

Closed
pwrzec1 opened this issue May 4, 2023 · 1 comment
Closed

Code correction in the file 'hid-uclogic-params.c' #658

pwrzec1 opened this issue May 4, 2023 · 1 comment

Comments

@pwrzec1
Copy link

pwrzec1 commented May 4, 2023

From the kernel 6.3, you must replace hid_is_using_ll_driver(hdev, &usb_hid_driver) with hid_is_usb(hdev).

I did it as follows:

Code:

#if KERNEL_VERSION(4, 14, 0) <= LINUX_VERSION_CODE
|| !hid_is_using_ll_driver(hdev, &usb_hid_driver)

I changed to:

#if LINUX_VERSION_CODE >= KERNEL_VERSION(6, 3, 0)
|| !hid_is_usb(hdev)
#elif KERNEL_VERSION(4, 14, 0) <= LINUX_VERSION_CODE
|| !hid_is_using_ll_driver(hdev, &usb_hid_driver)
#endif

I tested this change on the HUION Kamvas 13 tablet. This solution works well on my computer. The computer configuration:
Distribution: openSUSE Tumbleweed, kernel 6.3.1, AMD Ryzen 7 3700, 64GB RAM. Plasma on X11.

@goodspeed34
Copy link

already fixed in eca6e1b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants