Testing new URN format #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/middleware/parseUdi.ts
Outdated
|
|
||
| if (parts.length === 1 && parts[0].length !== 64) { | ||
| appendPath = `/${parts[0]}${appendPath}`; | ||
| } | ||
|
|
||
| if (parts.length === 3) { | ||
| if (parts.length === 5) { |
There was a problem hiding this comment.
It seems since we have the urn class, we might not need all this low level parsing login here?
There was a problem hiding this comment.
Agreed. I'll refactor that parsing into the udi class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a working version of the urn format for Udi. It contains the start of Udi sdk class.
This isn't ready for release but needs smoke testing. There are lot of function points in
parseUdiand I'm not sure I got them all covered.I'd like to factor the parsing of the Urn into the UDI class so we have that in one spot but want to make sure the new format works first.