Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are all the styles from the theme actually correct? #141

Open
bertearazvan opened this issue Jun 23, 2021 · 2 comments
Open

Are all the styles from the theme actually correct? #141

bertearazvan opened this issue Jun 23, 2021 · 2 comments
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@bertearazvan
Copy link
Contributor

bertearazvan commented Jun 23, 2021

Let's take this thread to report styling that we believe is not correct.

.MuiIconButton-root:hover:

  • There is a background color on hover. Is that really needed?

.MuiButton-root:

  • height should be 3rem?
  • padding should be really set?
@bertearazvan bertearazvan added help wanted Extra attention is needed question Further information is requested labels Jun 23, 2021
@rosudhi
Copy link
Contributor

rosudhi commented Jul 6, 2021

Should we discuss with designer teams regarding this? current styles comes from bit.dev codes. and i'm agree that there's some rooms for improvement things here.

@bertearazvan
Copy link
Contributor Author

Should we discuss with designer teams regarding this? current styles comes from bit.dev codes. and i'm agree that there's some rooms for improvement things here.

Yeah, I will have a meeting tomorrow in regards to some typography variants, I will tackle this as well. Meanwhile, feel free to update this issue with what you notice as you use the Theme in your own projects.

@rihr rihr closed this as completed Nov 4, 2021
@rihr rihr reopened this Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants