-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit test to components #122
Comments
Jest would be a good library I believe for achieving this. I think that for bigger components we should also do some integration testing and not only unit - just an idea. |
Yeap, i think we can use Also i agreed with @rihr that we may want to have a testing on react-component package instead of lab, but it would be nice if we have an Also i see What do you think @rihr @bertearazvan ? |
Not a bad idea, I don't mind adding in the tests, but I don't think we should add any more barriers to adding components in the lab - otherwise this will discourage some of us from sharing at all. |
agree
don't see the need of end-to-end testing since we are not testing apps
Yeah I think so, however we don't mainly depend on the testing pipeline to check if a component has changed or not, but rather also test it in the storybook. I would suggest sticking to basic unit testing for core and those snapshots (unsure how valuable they actually are)
Sounds like a good idea to add those, if anything |
I think this is the right time to add unit test to the components since they are small in number for now. If we add later when numbers are grow, we may overwhelmed.
Unit test is needed to make sure our component more robust, and bug less.
The text was updated successfully, but these errors were encountered: