Fix: v1.4.0-rc1 feedback issues & bugs #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves issue #55
This solves issue #57
sillydan1
force-pushed
the
fix/minor-rc-feedbacks
branch
from
6d70988 to
ccae65c
Compare
It messes up the diff for no (good) reason This also removes the extra boundry check when adding new locations, because it could fail catastrophically in some certain cases
sillydan1
changed the title
Nielswps
previously requested changes
Dec 9, 2022
src/main/java/dk/cs/aau/huppaal/presentations/TagPresentation.java
Outdated
Show resolved
Hide resolved
Yea 🤔 I was surprised too. I guess that if you need some more custom behavior, you'd just have to work around this behavior... |
sillydan1
dismissed
Nielswps’s stale review
All changes requested have been implemented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1.4.0-rc1 feedback
This PR solves the following problems: