Fix: dont escape utf8 characters when saving #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sillydan1
changed the title
sillydan1
force-pushed
the
fix/save-utf8-as-utf8
branch
from
8ddec0e to
8fd0f8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Dont escape utf8 characters in the
savefunctionThis PR fixes an issue where many characters would be escaped and would be very difficult for humans to read. Now the
savefunction will save characters as humanly readable text.Please note that this will affect all projects next time you save it.
Example
Old behavior: When saving a project that has an
guardwith the value:foo > 30, it would save a json filefoo \u003e 30.New behavior: When saving a project that has an
guardwith the value:foo > 30, it saves a json filefoo > 30.