From 0104512e7ea47e22c9b4042a81c4cf0449ef2295 Mon Sep 17 00:00:00 2001
From: Jason Claxton <30830544+Jozzey@users.noreply.github.com>
Date: Thu, 17 Aug 2023 09:49:56 +0100
Subject: [PATCH] Get Return Status as part of Matching Algorithm (#360)

https://eaflood.atlassian.net/browse/WATER-4081

As a billing and data user, I need the status of the returns to be assessed.

Once the charge element is matched to a return, the next step is to assess the status of the return, so that the relevant volumes and status can be recorded or error recorded.

This PR adds a new `returnStatus` array to the `chargeVersions` object displaying the unique statuses of the returns matched to the charge version.
---
 app/services/check/two-part.service.js | 59 ++++++++++++++------------
 1 file changed, 33 insertions(+), 26 deletions(-)

diff --git a/app/services/check/two-part.service.js b/app/services/check/two-part.service.js
index 5ac41fb993..bae33bb951 100644
--- a/app/services/check/two-part.service.js
+++ b/app/services/check/two-part.service.js
@@ -89,35 +89,42 @@ async function _fetchChargeVersions (billingPeriod, naldRegionId) {
 
 async function _fetchAndApplyReturns (billingPeriod, chargeVersion) {
   const { licenceRef, chargeElements } = chargeVersion
+  const cumulativeReturnStatuses = []
 
   for (const chargeElement of chargeElements) {
-    const { chargePurposes } = chargeElement
-
-    for (const chargePurpose of chargePurposes) {
-      const legacyId = chargePurpose.purposesUse.legacyId
-
-      chargePurpose.returns = await ReturnModel.query()
-        .select([
-          'returnId',
-          'returnRequirement',
-          'startDate',
-          'endDate',
-          'status',
-          'metadata'
-        ])
-        .where('licenceRef', licenceRef)
-        // water-abstraction-service filters out old returns in this way: `src/lib/services/returns/api-connector.js`
-        .where('startDate', '>=', '2008-04-01')
-        .where('startDate', '<=', billingPeriod.endDate)
-        .where('endDate', '>=', billingPeriod.startDate)
-        .whereJsonPath('metadata', '$.isTwoPartTariff', '=', true)
-        .where(ref('metadata:purposes[0].tertiary.code').castInt(), legacyId)
-
-      chargePurpose.returnStatus = chargePurpose.returns.map((matchedReturn) => {
-        return matchedReturn.status
-      })
-    }
+    const purposeUseLegacyIds = _extractPurposeUseLegacyIds(chargeElement)
+
+    chargeElement.returns = await ReturnModel.query()
+      .select([
+        'returnId',
+        'returnRequirement',
+        'startDate',
+        'endDate',
+        'status',
+        'metadata'
+      ])
+      .where('licenceRef', licenceRef)
+      // water-abstraction-service filters out old returns in this way: `src/lib/services/returns/api-connector.js`
+      .where('startDate', '>=', '2008-04-01')
+      .where('startDate', '<=', billingPeriod.endDate)
+      .where('endDate', '>=', billingPeriod.startDate)
+      .whereJsonPath('metadata', '$.isTwoPartTariff', '=', true)
+      .whereIn(ref('metadata:purposes[0].tertiary.code').castInt(), purposeUseLegacyIds)
+
+    const chargeElementReturnStatuses = chargeElement.returns.map((matchedReturn) => {
+      return matchedReturn.status
+    })
+
+    cumulativeReturnStatuses.push(...chargeElementReturnStatuses)
   }
+
+  chargeVersion.returnStatuses = [...new Set(cumulativeReturnStatuses)]
+}
+
+function _extractPurposeUseLegacyIds (chargeElement) {
+  return chargeElement.chargePurposes.map((chargePurpose) => {
+    return chargePurpose.purposesUse.legacyId
+  })
 }
 
 function _matchChargeVersions (chargeVersions) {