Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerize the shiny app #10

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Dockerize the shiny app #10

wants to merge 6 commits into from

Conversation

colinxfleming
Copy link
Member

@colinxfleming colinxfleming commented Nov 24, 2019

This sets up a docker container to run the shiny server, albeit ugly.

I didn't do a volume - the image needs shiny stuff to be set up in /srv/shiny-server and I'm not savvy enough to figure that out. But, like, starting the server works!

@DarthHater could you spot check my work here, and if you want suggest any linux pkgs to add in setup given that we'll probably be running something similar to this in prod, I'm def all ears. These images are debian based, I believe. You should be able to recreate with instructions in the readme.

Fixes #9
Bumps #3

@DarthHater
Copy link
Member

Based on my reading of the base shiny image I see:

https://github.com/rocker-org/shiny#connecting-app-and-log-directories-to-host

or:

https://github.com/rocker-org/shiny/blob/master/docker-compose.yml#L27

As well from their example docker-compose.yml: https://github.com/rocker-org/shiny/blob/master/docker-compose.yml#L23

I haven't run this yet but mounting logs to a local volume sounds good in theory, makes the app less stateful (you can kill the docker etc... and the logs live on somewhere)

In their example docker-compose.yml they have it run under root to run on port 80, is there a config for port? I'd imagine a production deployment of this would use nginx in front of it so you could pass 443 to whatever port you have open. Just curious on that!

@colinxfleming
Copy link
Member Author

colinxfleming commented Nov 24, 2019

I think for the port thing that's going to be pretty dependent on heroku, which I think doesn't do compose, so we can figure that out when we get to it.

The logs thing totally doable, I rigged up a log dir appropriately. Let me see if I can set up the app itself to link with a volume too.

@colinxfleming
Copy link
Member Author

rough edges should be sanded off now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a dependencies file
2 participants