Skip to content

Commit 0bf4c45

Browse files
committed
Post-hoc feedback from #1145
1 parent e7d1a14 commit 0bf4c45

File tree

2 files changed

+3
-3
lines changed
  • examples/scikit-learn/species_distribution_modeling
  • hamilton/function_modifiers

2 files changed

+3
-3
lines changed

examples/scikit-learn/species_distribution_modeling/README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ qux(baz(foo(bar)))
5353
```
5454

5555
This can be particularly useful when:
56-
1. Ensuring consi
56+
1. Ensuring consistency between transforms/data processing steps across different nodes.
5757
2. Re-using the same function on multiple nodes. For example, needing to do different pre-processing, but than passing data to the same `model`, aka feature engineering hyper-tuning.
5858
3. We can also use `step(...).when(...)` and can choose at execution time which transformation will be applied to the output of a particular node. For example, each `step` represents a different `model` and we switch between them with a config dictionary in the Hamilton driver.
5959

@@ -70,7 +70,7 @@ so that it does not run when imported into other scripts.
7070
This script can be run as is for comparison. Actually the external functions `construct_grids()` and `create_species_bunch()` we will directly import and use as external functions to showcase how you can use our `pipe` and `pipe_output` functionality to "Hamiltonise" external modules.
7171

7272
## hamilton_notebook.ipynb
73-
Is a nodebook that contains all the modules and has the execution cells to run the complete code. It also gives you the ability to visualize the DAG.
73+
Is a notebook that contains all the modules and has the execution cells to run the complete code. It also gives you the ability to visualize the DAG.
7474

7575
## run.py
7676
If you prefer to run code through a shell the same code is also available as a python script.

hamilton/function_modifiers/macros.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -905,7 +905,7 @@ def B(...):
905905
B1, takes the output of B1 applies to it B2 and then gets renamed to B to re-connect to the rest of the DAG.
906906
907907
While it is generally reasonable to contain these constructs within a node's function,
908-
you should consider `pipe_output` for similar reasons as `pipe`, namely, for any of the following reasons:
908+
you should consider `pipe_output` for similar reasons as `pipe_input`, namely, for any of the following reasons:
909909
910910
1. You want the transformations to display as nodes in the DAG, with the possibility of storing or visualizing
911911
the result

0 commit comments

Comments
 (0)