Merge pull request microsoft#4555 from iclanton/sleep-0

Update 1ms sleeps in tests to 0ms

Author: iclanton

common/changes/@rushstack/node-core-library/sleep-0_2024-02-28-19-54.json

@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "comment": "",
+      "type": "none",
+      "packageName": "@rushstack/node-core-library"
+    }
+  ],
+  "packageName": "@rushstack/node-core-library",
+  "email": "[email protected]"
+}

common/changes/@rushstack/operation-graph/sleep-0_2024-02-28-19-54.json

@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "comment": "",
+      "type": "none",
+      "packageName": "@rushstack/operation-graph"
+    }
+  ],
+  "packageName": "@rushstack/operation-graph",
+  "email": "[email protected]"
+}

libraries/node-core-library/src/test/Async.test.ts

@@ -42,7 +42,7 @@ describe(Async.name, () => {
 
       const fn: (item: number) => Promise<string> = async (item) => {
         running++;
-        await Async.sleep(1);
+        await Async.sleep(0);
         maxRunning = Math.max(maxRunning, running);
         running--;
         return `result ${item}`;
@@ -137,7 +137,7 @@ describe(Async.name, () => {
 
       const fn: (item: number) => Promise<void> = jest.fn(async (item) => {
         running++;
-        await Async.sleep(1);
+        await Async.sleep(0);
         maxRunning = Math.max(maxRunning, running);
         running--;
       });
@@ -155,7 +155,7 @@ describe(Async.name, () => {
 
       const fn: (item: number) => Promise<void> = jest.fn(async (item) => {
         running++;
-        await Async.sleep(1);
+        await Async.sleep(0);
         maxRunning = Math.max(maxRunning, running);
         running--;
       });
@@ -171,14 +171,14 @@ describe(Async.name, () => {
         array.push(i);
       }
 
-      await Async.forEachAsync(array, async () => await Async.sleep(1), { concurrency: 3 });
+      await Async.forEachAsync(array, async () => await Async.sleep(0), { concurrency: 3 });
     });
 
     it('rejects if any operation rejects', async () => {
       const array: number[] = [1, 2, 3];
 
       const fn: (item: number) => Promise<void> = jest.fn(async (item) => {
-        await Async.sleep(1);
+        await Async.sleep(0);
         if (item === 3) throw new Error('Something broke');
       });
 
@@ -223,7 +223,7 @@ describe(Async.name, () => {
       };
 
       await expect(() =>
-        Async.forEachAsync(syncIterable, async (item) => await Async.sleep(1))
+        Async.forEachAsync(syncIterable, async (item) => await Async.sleep(0))
       ).rejects.toThrow(expectedError);
     });
 
@@ -245,7 +245,7 @@ describe(Async.name, () => {
       };
 
       await expect(() =>
-        Async.forEachAsync(syncIterable, async (item) => await Async.sleep(1))
+        Async.forEachAsync(syncIterable, async (item) => await Async.sleep(0))
       ).rejects.toThrow(expectedError);
     });
 
@@ -285,7 +285,7 @@ describe(Async.name, () => {
       );
 
       // Wait for all the instant resolutions to be done
-      await Async.sleep(1);
+      await Async.sleep(0);
       expect(waitingIterators).toEqual(expectedConcurrency);
       resolve2({ done: true, value: undefined });
       await finalPromise;
@@ -309,7 +309,7 @@ describe(Async.name, () => {
       };
 
       await expect(() =>
-        Async.forEachAsync(syncIterable, async (item) => await Async.sleep(1))
+        Async.forEachAsync(syncIterable, async (item) => await Async.sleep(0))
       ).rejects.toThrow(expectedError);
     });
   });
@@ -516,7 +516,7 @@ describe(AsyncQueue.name, () => {
       queue,
       async ([item, callback]) => {
         // Add an async tick to ensure that the queue is actually running concurrently
-        await Async.sleep(1);
+        await Async.sleep(0);
         seenItems++;
         expect(expectedItems.has(item)).toBe(true);
         expectedItems.delete(item);
@@ -543,7 +543,7 @@ describe(AsyncQueue.name, () => {
       queue,
       async ([item, callback]) => {
         // Add an async tick to ensure that the queue is actually running concurrently
-        await Async.sleep(1);
+        await Async.sleep(0);
         seenItems++;
         if (item < 4) {
           expect(expectedItems.has(item)).toBe(true);
@@ -577,7 +577,7 @@ describe(AsyncQueue.name, () => {
       queue,
       async ([item, callback]) => {
         // Add an async tick to ensure that the queue is actually running concurrently
-        await Async.sleep(1);
+        await Async.sleep(0);
         seenItems++;
         if (item < 4) {
           expect(expectedItems.has(item)).toBe(true);

libraries/operation-graph/src/test/OperationExecutionManager.test.ts

@@ -287,7 +287,7 @@ describe(OperationExecutionManager.name, () => {
         const run: ExecuteAsyncMock = jest.fn(
           async (context: IOperationRunnerContext): Promise<OperationStatus> => {
             ++concurrency;
-            await Async.sleep(1);
+            await Async.sleep(0);
             if (concurrency > maxConcurrency) {
               maxConcurrency = concurrency;
             }

libraries/operation-graph/src/test/WorkQueue.test.ts

@@ -128,7 +128,7 @@ describe(WorkQueue.name, () => {
 
     const fn: () => Promise<OperationStatus> = jest.fn(async () => {
       running++;
-      await Async.sleep(1);
+      await Async.sleep(0);
       maxRunning = Math.max(maxRunning, running);
       running--;
       return OperationStatus.Success;