From f9ad56e720f926cd74da1d1854ef2c3547f2edce Mon Sep 17 00:00:00 2001 From: Ikiru Yoshizaki <3856350+guitarrapc@users.noreply.github.com> Date: Wed, 24 Sep 2025 15:51:05 +0900 Subject: [PATCH] chore: Specify IsPackable=false on Directory.Build.props, explicitly true for target packages. --- .gitignore | 14 +++++++++++++- Directory.Build.props | 3 +++ src/MagicOnion/Icon.png => Icon.png | Bin .../PerformanceTest.Client.csproj | 1 - .../PerformanceTest.Server.csproj | 1 - .../PerformanceTest.Shared.csproj | 1 - .../Microbenchmark.Client.csproj | 1 - .../SourceGeneratorPerf.csproj | 1 - .../ChatApp/ChatApp.Shared/Directory.Build.props | 8 +++++--- .../JsonTranscodingSample.Server.csproj | 1 - .../JsonTranscodingSample.Shared.csproj | 1 - .../JwtAuthApp.Client/JwtAuthApp.Client.csproj | 1 - .../JwtAuthApp.Server/JwtAuthApp.Server.csproj | 1 - .../JwtAuthApp.Shared/JwtAuthApp.Shared.csproj | 1 - src/Directory.Build.props | 3 --- .../MagicOnion.Abstractions.csproj | 2 ++ src/MagicOnion.Client/MagicOnion.Client.csproj | 1 + .../MagicOnion.Serialization.MemoryPack.csproj | 1 + .../MagicOnion.Serialization.MessagePack.csproj | 1 + ...gicOnion.Server.JsonTranscoding.Swagger.csproj | 1 + .../MagicOnion.Server.JsonTranscoding.csproj | 1 + .../MagicOnion.Server.Redis.csproj | 1 + src/MagicOnion.Server/MagicOnion.Server.csproj | 1 + src/MagicOnion.Shared/MagicOnion.Shared.csproj | 4 +++- src/MagicOnion/MagicOnion.csproj | 1 + .../MagicOnion.Abstractions.Tests.csproj | 2 -- .../MagicOnion.Client.NativeAot.Tests.csproj | 1 - ...MagicOnion.Client.SourceGenerator.Tests.csproj | 2 -- .../MagicOnion.Client.Tests.csproj | 1 - .../MagicOnion.Integration.Tests.csproj | 2 -- ...gicOnion.Serialization.MemoryPack.Tests.csproj | 2 -- ...icOnion.Serialization.MessagePack.Tests.csproj | 2 -- .../MagicOnion.Server.InternalTesting.csproj | 1 - ...MagicOnion.Server.JsonTranscoding.Tests.csproj | 1 - .../MagicOnion.Server.Redis.Tests.csproj | 2 -- .../MagicOnion.Server.Tests.csproj | 1 - tests/samples/AuthSample/AuthSample.csproj | 1 - .../MagicOnionEngineTest.csproj | 1 - .../MagicOnionTestServer.csproj | 1 - .../SampleServiceDefinitions.csproj | 1 - 40 files changed, 34 insertions(+), 39 deletions(-) rename src/MagicOnion/Icon.png => Icon.png (100%) diff --git a/.gitignore b/.gitignore index a3eff8378..61950e37b 100644 --- a/.gitignore +++ b/.gitignore @@ -77,7 +77,19 @@ publish *.Publish.xml # NuGet Packages Directory +*.nupkg +# NuGet Symbol Packages +*.snupkg +# The packages folder can be ignored because of Package Restore # packages # upm pacakge will use Packages +# **/[Pp]ackages/* +# except build/, which is used as an MSBuild target. +# !**/[Pp]ackages/build/ +# Uncomment if necessary however generally it will be regenerated when needed +#!**/[Pp]ackages/repositories.config +# NuGet v3's project.json files produces more ignorable files +*.nuget.props +*.nuget.targets # Windows Azure Build Output csx @@ -137,4 +149,4 @@ packages # Node -node_modules/ \ No newline at end of file +node_modules/ diff --git a/Directory.Build.props b/Directory.Build.props index e75e07851..0ca568ff3 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -11,6 +11,7 @@ + false $(Version) Cysharp Cysharp @@ -32,7 +33,9 @@ + + diff --git a/src/MagicOnion/Icon.png b/Icon.png similarity index 100% rename from src/MagicOnion/Icon.png rename to Icon.png diff --git a/perf/BenchmarkApp/PerformanceTest.Client/PerformanceTest.Client.csproj b/perf/BenchmarkApp/PerformanceTest.Client/PerformanceTest.Client.csproj index 59b713893..d8eed7d1a 100644 --- a/perf/BenchmarkApp/PerformanceTest.Client/PerformanceTest.Client.csproj +++ b/perf/BenchmarkApp/PerformanceTest.Client/PerformanceTest.Client.csproj @@ -6,7 +6,6 @@ enable enable CLIENT;$(DefineConstants) - false diff --git a/perf/BenchmarkApp/PerformanceTest.Server/PerformanceTest.Server.csproj b/perf/BenchmarkApp/PerformanceTest.Server/PerformanceTest.Server.csproj index 5e9e0a4ec..712ab79eb 100644 --- a/perf/BenchmarkApp/PerformanceTest.Server/PerformanceTest.Server.csproj +++ b/perf/BenchmarkApp/PerformanceTest.Server/PerformanceTest.Server.csproj @@ -5,7 +5,6 @@ enable enable SERVER;$(DefineConstants) - false diff --git a/perf/BenchmarkApp/PerformanceTest.Shared/PerformanceTest.Shared.csproj b/perf/BenchmarkApp/PerformanceTest.Shared/PerformanceTest.Shared.csproj index 534870a64..d3d7cc5da 100644 --- a/perf/BenchmarkApp/PerformanceTest.Shared/PerformanceTest.Shared.csproj +++ b/perf/BenchmarkApp/PerformanceTest.Shared/PerformanceTest.Shared.csproj @@ -4,7 +4,6 @@ net9.0 enable enable - false diff --git a/perf/Microbenchmark/Microbenchmark.Client/Microbenchmark.Client.csproj b/perf/Microbenchmark/Microbenchmark.Client/Microbenchmark.Client.csproj index 53b7ce16d..64dab9f3c 100644 --- a/perf/Microbenchmark/Microbenchmark.Client/Microbenchmark.Client.csproj +++ b/perf/Microbenchmark/Microbenchmark.Client/Microbenchmark.Client.csproj @@ -5,7 +5,6 @@ net8.0 enable enable - false true ..\..\..\src\MagicOnion\opensource.snk diff --git a/perf/SourceGeneratorPerf/SourceGeneratorPerf/SourceGeneratorPerf.csproj b/perf/SourceGeneratorPerf/SourceGeneratorPerf/SourceGeneratorPerf.csproj index 85281ce79..72ac67c8c 100644 --- a/perf/SourceGeneratorPerf/SourceGeneratorPerf/SourceGeneratorPerf.csproj +++ b/perf/SourceGeneratorPerf/SourceGeneratorPerf/SourceGeneratorPerf.csproj @@ -5,7 +5,6 @@ net8.0 enable enable - false diff --git a/samples/ChatApp/ChatApp.Shared/Directory.Build.props b/samples/ChatApp/ChatApp.Shared/Directory.Build.props index 5f2b4b91c..76234e5d5 100644 --- a/samples/ChatApp/ChatApp.Shared/Directory.Build.props +++ b/samples/ChatApp/ChatApp.Shared/Directory.Build.props @@ -1,8 +1,10 @@ - diff --git a/samples/JsonTranscoding/JsonTranscodingSample.Server/JsonTranscodingSample.Server.csproj b/samples/JsonTranscoding/JsonTranscodingSample.Server/JsonTranscodingSample.Server.csproj index aee3688b5..cd5adaab9 100644 --- a/samples/JsonTranscoding/JsonTranscodingSample.Server/JsonTranscodingSample.Server.csproj +++ b/samples/JsonTranscoding/JsonTranscodingSample.Server/JsonTranscodingSample.Server.csproj @@ -4,7 +4,6 @@ net8.0 enable enable - false diff --git a/samples/JsonTranscoding/JsonTranscodingSample.Shared/JsonTranscodingSample.Shared.csproj b/samples/JsonTranscoding/JsonTranscodingSample.Shared/JsonTranscodingSample.Shared.csproj index 288874de2..5337dfeb8 100644 --- a/samples/JsonTranscoding/JsonTranscodingSample.Shared/JsonTranscodingSample.Shared.csproj +++ b/samples/JsonTranscoding/JsonTranscodingSample.Shared/JsonTranscodingSample.Shared.csproj @@ -5,7 +5,6 @@ enable enable true - false diff --git a/samples/JwtAuthentication/JwtAuthApp.Client/JwtAuthApp.Client.csproj b/samples/JwtAuthentication/JwtAuthApp.Client/JwtAuthApp.Client.csproj index 4da5ca75b..199ba6a58 100644 --- a/samples/JwtAuthentication/JwtAuthApp.Client/JwtAuthApp.Client.csproj +++ b/samples/JwtAuthentication/JwtAuthApp.Client/JwtAuthApp.Client.csproj @@ -5,7 +5,6 @@ net8.0 enable enable - false diff --git a/samples/JwtAuthentication/JwtAuthApp.Server/JwtAuthApp.Server.csproj b/samples/JwtAuthentication/JwtAuthApp.Server/JwtAuthApp.Server.csproj index 986a79209..6c8353f2b 100644 --- a/samples/JwtAuthentication/JwtAuthApp.Server/JwtAuthApp.Server.csproj +++ b/samples/JwtAuthentication/JwtAuthApp.Server/JwtAuthApp.Server.csproj @@ -5,7 +5,6 @@ net8.0 enable latest - false diff --git a/samples/JwtAuthentication/JwtAuthApp.Shared/JwtAuthApp.Shared.csproj b/samples/JwtAuthentication/JwtAuthApp.Shared/JwtAuthApp.Shared.csproj index 4aea79176..de0cf7c9d 100644 --- a/samples/JwtAuthentication/JwtAuthApp.Shared/JwtAuthApp.Shared.csproj +++ b/samples/JwtAuthentication/JwtAuthApp.Shared/JwtAuthApp.Shared.csproj @@ -2,7 +2,6 @@ netstandard2.0 - false diff --git a/src/Directory.Build.props b/src/Directory.Build.props index 6030d05ea..1435f0fec 100644 --- a/src/Directory.Build.props +++ b/src/Directory.Build.props @@ -17,7 +17,4 @@ $(RepoRoot)=. - - - diff --git a/src/MagicOnion.Abstractions/MagicOnion.Abstractions.csproj b/src/MagicOnion.Abstractions/MagicOnion.Abstractions.csproj index b15e29714..a376d4c07 100644 --- a/src/MagicOnion.Abstractions/MagicOnion.Abstractions.csproj +++ b/src/MagicOnion.Abstractions/MagicOnion.Abstractions.csproj @@ -7,6 +7,8 @@ enable true + + true MagicOnion.Abstractions MagicOnion interfaces and abstractions for server and client. Commonly used types: diff --git a/src/MagicOnion.Client/MagicOnion.Client.csproj b/src/MagicOnion.Client/MagicOnion.Client.csproj index f8c69d051..dff2a95ff 100644 --- a/src/MagicOnion.Client/MagicOnion.Client.csproj +++ b/src/MagicOnion.Client/MagicOnion.Client.csproj @@ -8,6 +8,7 @@ true + true MagicOnion.Client MagicOnion client-side runtime library. $(MagicOnionPackageDescription) diff --git a/src/MagicOnion.Serialization.MemoryPack/MagicOnion.Serialization.MemoryPack.csproj b/src/MagicOnion.Serialization.MemoryPack/MagicOnion.Serialization.MemoryPack.csproj index 51a5ea82a..f1f582910 100644 --- a/src/MagicOnion.Serialization.MemoryPack/MagicOnion.Serialization.MemoryPack.csproj +++ b/src/MagicOnion.Serialization.MemoryPack/MagicOnion.Serialization.MemoryPack.csproj @@ -7,6 +7,7 @@ enable + true MagicOnion.Serialization.MemoryPack MagicOnion extension package for serialization using MemoryPack. preview diff --git a/src/MagicOnion.Serialization.MessagePack/MagicOnion.Serialization.MessagePack.csproj b/src/MagicOnion.Serialization.MessagePack/MagicOnion.Serialization.MessagePack.csproj index 4ec87bb50..52c7e41e3 100644 --- a/src/MagicOnion.Serialization.MessagePack/MagicOnion.Serialization.MessagePack.csproj +++ b/src/MagicOnion.Serialization.MessagePack/MagicOnion.Serialization.MessagePack.csproj @@ -9,6 +9,7 @@ true + true MagicOnion.Serialization.MessagePack MagicOnion extension package for serialization using MessagePack. diff --git a/src/MagicOnion.Server.JsonTranscoding.Swagger/MagicOnion.Server.JsonTranscoding.Swagger.csproj b/src/MagicOnion.Server.JsonTranscoding.Swagger/MagicOnion.Server.JsonTranscoding.Swagger.csproj index 04de5e676..27aa05265 100644 --- a/src/MagicOnion.Server.JsonTranscoding.Swagger/MagicOnion.Server.JsonTranscoding.Swagger.csproj +++ b/src/MagicOnion.Server.JsonTranscoding.Swagger/MagicOnion.Server.JsonTranscoding.Swagger.csproj @@ -6,6 +6,7 @@ enable + true MagicOnion.Server.JsonTranscoding.Swagger Provides Swagger support for MagicOnion JSON transcoding on the server. diff --git a/src/MagicOnion.Server.JsonTranscoding/MagicOnion.Server.JsonTranscoding.csproj b/src/MagicOnion.Server.JsonTranscoding/MagicOnion.Server.JsonTranscoding.csproj index ece1d1547..c11329542 100644 --- a/src/MagicOnion.Server.JsonTranscoding/MagicOnion.Server.JsonTranscoding.csproj +++ b/src/MagicOnion.Server.JsonTranscoding/MagicOnion.Server.JsonTranscoding.csproj @@ -6,6 +6,7 @@ enable + true MagicOnion.Server.JsonTranscoding Provides JSON transcoding support to the MagicOnion server. diff --git a/src/MagicOnion.Server.Redis/MagicOnion.Server.Redis.csproj b/src/MagicOnion.Server.Redis/MagicOnion.Server.Redis.csproj index 3a3b7f73c..ac5bf109d 100644 --- a/src/MagicOnion.Server.Redis/MagicOnion.Server.Redis.csproj +++ b/src/MagicOnion.Server.Redis/MagicOnion.Server.Redis.csproj @@ -9,6 +9,7 @@ $(NoWarn);1701;1702;1705;1591 + true MagicOnion.Server.Redis Redis backplane for MagicOnion. diff --git a/src/MagicOnion.Server/MagicOnion.Server.csproj b/src/MagicOnion.Server/MagicOnion.Server.csproj index 9cc08af47..a9865bf36 100644 --- a/src/MagicOnion.Server/MagicOnion.Server.csproj +++ b/src/MagicOnion.Server/MagicOnion.Server.csproj @@ -9,6 +9,7 @@ $(DefineConstants);USE_OBJECTPOOL_STREAMINGHUBPAYLOADPOOL + true MagicOnion.Server MagicOnion server built on top of ASP.NET Core. $(MagicOnionPackageDescription) diff --git a/src/MagicOnion.Shared/MagicOnion.Shared.csproj b/src/MagicOnion.Shared/MagicOnion.Shared.csproj index ad5820abe..cad48041e 100644 --- a/src/MagicOnion.Shared/MagicOnion.Shared.csproj +++ b/src/MagicOnion.Shared/MagicOnion.Shared.csproj @@ -5,8 +5,10 @@ enable enable - MagicOnion + + + true Provides shared classes and interfaces used by MagicOnion server and client. $(MagicOnionPackageDescription) diff --git a/src/MagicOnion/MagicOnion.csproj b/src/MagicOnion/MagicOnion.csproj index 8a878657b..32e32d034 100644 --- a/src/MagicOnion/MagicOnion.csproj +++ b/src/MagicOnion/MagicOnion.csproj @@ -6,6 +6,7 @@ False + true MagicOnion $(MagicOnionPackageDescription) This package is meta package that includes MagicOnion.Server and MagicOnion.Client. diff --git a/tests/MagicOnion.Abstractions.Tests/MagicOnion.Abstractions.Tests.csproj b/tests/MagicOnion.Abstractions.Tests/MagicOnion.Abstractions.Tests.csproj index 4df94ab43..1cc8784d5 100644 --- a/tests/MagicOnion.Abstractions.Tests/MagicOnion.Abstractions.Tests.csproj +++ b/tests/MagicOnion.Abstractions.Tests/MagicOnion.Abstractions.Tests.csproj @@ -4,8 +4,6 @@ net8.0 enable enable - - false diff --git a/tests/MagicOnion.Client.NativeAot.Tests/MagicOnion.Client.NativeAot.Tests.csproj b/tests/MagicOnion.Client.NativeAot.Tests/MagicOnion.Client.NativeAot.Tests.csproj index e91934e88..d141f78f8 100644 --- a/tests/MagicOnion.Client.NativeAot.Tests/MagicOnion.Client.NativeAot.Tests.csproj +++ b/tests/MagicOnion.Client.NativeAot.Tests/MagicOnion.Client.NativeAot.Tests.csproj @@ -5,7 +5,6 @@ latest enable enable - false exe true diff --git a/tests/MagicOnion.Client.SourceGenerator.Tests/MagicOnion.Client.SourceGenerator.Tests.csproj b/tests/MagicOnion.Client.SourceGenerator.Tests/MagicOnion.Client.SourceGenerator.Tests.csproj index 633ae8546..abef39626 100644 --- a/tests/MagicOnion.Client.SourceGenerator.Tests/MagicOnion.Client.SourceGenerator.Tests.csproj +++ b/tests/MagicOnion.Client.SourceGenerator.Tests/MagicOnion.Client.SourceGenerator.Tests.csproj @@ -5,8 +5,6 @@ latest enable enable - - false diff --git a/tests/MagicOnion.Client.Tests/MagicOnion.Client.Tests.csproj b/tests/MagicOnion.Client.Tests/MagicOnion.Client.Tests.csproj index 1c741997f..d9c5e5300 100644 --- a/tests/MagicOnion.Client.Tests/MagicOnion.Client.Tests.csproj +++ b/tests/MagicOnion.Client.Tests/MagicOnion.Client.Tests.csproj @@ -4,7 +4,6 @@ net8.0 enable enable - false true ..\..\src\MagicOnion\opensource.snk diff --git a/tests/MagicOnion.Integration.Tests/MagicOnion.Integration.Tests.csproj b/tests/MagicOnion.Integration.Tests/MagicOnion.Integration.Tests.csproj index c5d7d49a1..ae27f22f5 100644 --- a/tests/MagicOnion.Integration.Tests/MagicOnion.Integration.Tests.csproj +++ b/tests/MagicOnion.Integration.Tests/MagicOnion.Integration.Tests.csproj @@ -4,8 +4,6 @@ net8.0 enable enable - - false diff --git a/tests/MagicOnion.Serialization.MemoryPack.Tests/MagicOnion.Serialization.MemoryPack.Tests.csproj b/tests/MagicOnion.Serialization.MemoryPack.Tests/MagicOnion.Serialization.MemoryPack.Tests.csproj index cb8855562..e7bf14d85 100644 --- a/tests/MagicOnion.Serialization.MemoryPack.Tests/MagicOnion.Serialization.MemoryPack.Tests.csproj +++ b/tests/MagicOnion.Serialization.MemoryPack.Tests/MagicOnion.Serialization.MemoryPack.Tests.csproj @@ -4,8 +4,6 @@ net8.0 enable enable - - false diff --git a/tests/MagicOnion.Serialization.MessagePack.Tests/MagicOnion.Serialization.MessagePack.Tests.csproj b/tests/MagicOnion.Serialization.MessagePack.Tests/MagicOnion.Serialization.MessagePack.Tests.csproj index cb2dff7f5..0aa9956b7 100644 --- a/tests/MagicOnion.Serialization.MessagePack.Tests/MagicOnion.Serialization.MessagePack.Tests.csproj +++ b/tests/MagicOnion.Serialization.MessagePack.Tests/MagicOnion.Serialization.MessagePack.Tests.csproj @@ -4,8 +4,6 @@ net8.0 enable enable - - false diff --git a/tests/MagicOnion.Server.InternalTesting/MagicOnion.Server.InternalTesting.csproj b/tests/MagicOnion.Server.InternalTesting/MagicOnion.Server.InternalTesting.csproj index f0c9da63a..03ed57b98 100644 --- a/tests/MagicOnion.Server.InternalTesting/MagicOnion.Server.InternalTesting.csproj +++ b/tests/MagicOnion.Server.InternalTesting/MagicOnion.Server.InternalTesting.csproj @@ -4,7 +4,6 @@ net8.0 enable enable - false true ..\..\src\MagicOnion\opensource.snk diff --git a/tests/MagicOnion.Server.JsonTranscoding.Tests/MagicOnion.Server.JsonTranscoding.Tests.csproj b/tests/MagicOnion.Server.JsonTranscoding.Tests/MagicOnion.Server.JsonTranscoding.Tests.csproj index 0561a8af2..6d25f4ed0 100644 --- a/tests/MagicOnion.Server.JsonTranscoding.Tests/MagicOnion.Server.JsonTranscoding.Tests.csproj +++ b/tests/MagicOnion.Server.JsonTranscoding.Tests/MagicOnion.Server.JsonTranscoding.Tests.csproj @@ -5,7 +5,6 @@ enable enable - false true true diff --git a/tests/MagicOnion.Server.Redis.Tests/MagicOnion.Server.Redis.Tests.csproj b/tests/MagicOnion.Server.Redis.Tests/MagicOnion.Server.Redis.Tests.csproj index e3157d9b7..2bdcfb7f0 100644 --- a/tests/MagicOnion.Server.Redis.Tests/MagicOnion.Server.Redis.Tests.csproj +++ b/tests/MagicOnion.Server.Redis.Tests/MagicOnion.Server.Redis.Tests.csproj @@ -4,8 +4,6 @@ net8.0 enable enable - - false diff --git a/tests/MagicOnion.Server.Tests/MagicOnion.Server.Tests.csproj b/tests/MagicOnion.Server.Tests/MagicOnion.Server.Tests.csproj index b5fa3c344..80e1dd28f 100644 --- a/tests/MagicOnion.Server.Tests/MagicOnion.Server.Tests.csproj +++ b/tests/MagicOnion.Server.Tests/MagicOnion.Server.Tests.csproj @@ -4,7 +4,6 @@ net8.0 default enable - false true ..\..\src\MagicOnion\opensource.snk diff --git a/tests/samples/AuthSample/AuthSample.csproj b/tests/samples/AuthSample/AuthSample.csproj index 2b9eb7461..91e29c1e7 100644 --- a/tests/samples/AuthSample/AuthSample.csproj +++ b/tests/samples/AuthSample/AuthSample.csproj @@ -4,7 +4,6 @@ net8.0 enable enable - false diff --git a/tests/samples/MagicOnionEngineTest/MagicOnionEngineTest.csproj b/tests/samples/MagicOnionEngineTest/MagicOnionEngineTest.csproj index 82f402f40..ccd3af8bb 100644 --- a/tests/samples/MagicOnionEngineTest/MagicOnionEngineTest.csproj +++ b/tests/samples/MagicOnionEngineTest/MagicOnionEngineTest.csproj @@ -4,7 +4,6 @@ net8.0 enable enable - false diff --git a/tests/samples/MagicOnionTestServer/MagicOnionTestServer.csproj b/tests/samples/MagicOnionTestServer/MagicOnionTestServer.csproj index 4f3879326..96bb8a0be 100644 --- a/tests/samples/MagicOnionTestServer/MagicOnionTestServer.csproj +++ b/tests/samples/MagicOnionTestServer/MagicOnionTestServer.csproj @@ -4,7 +4,6 @@ net8.0 enable enable - false true ..\..\..\src\MagicOnion\opensource.snk diff --git a/tests/samples/SampleServiceDefinitions/SampleServiceDefinitions.csproj b/tests/samples/SampleServiceDefinitions/SampleServiceDefinitions.csproj index e908b6624..cfbb899f3 100644 --- a/tests/samples/SampleServiceDefinitions/SampleServiceDefinitions.csproj +++ b/tests/samples/SampleServiceDefinitions/SampleServiceDefinitions.csproj @@ -4,7 +4,6 @@ netstandard2.1 enable latest - false