Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upvote on comments #125

Open
neozenweb opened this issue Feb 14, 2019 · 1 comment
Open

Upvote on comments #125

neozenweb opened this issue Feb 14, 2019 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@neozenweb
Copy link
Contributor

Describe the bug
I. Upvote on new comment does not work or show anything.
II. Upvote on existing comments toggles the values 1,0 or 1,2

To Reproduce
Steps to reproduce the behavior:

  1. Click on profile.
  2. Click on a project.
  3. On the Left hand side menu scroll down to checkpoints.
  4. Click on one of the checkpoints
  5. Add a new comment and click Upvote (for part I)
  6. Click Upvote for existing comments (for Part II)

Expected behavior
Upvote should increase the comment votes starting at 1 and increasing on wards.

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser chrome, Edge
@WickedBrat
Copy link
Member

WickedBrat commented Feb 14, 2019

@neozenweb The first part is indeed an issue but that's not the case with the second part. We don't want to allow a single user to upvote a comment multiple times.

In addition to this, I suppose the best fix would be to change the color of the text Upvote (1) once it has been upvoted by the user, indicating that when clicked, it'll remove the upvote.

@WickedBrat WickedBrat added bug Something isn't working good first issue Good for newcomers labels Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants