Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar and style check #492

Open
stevespringett opened this issue Jul 11, 2024 · 0 comments
Open

Grammar and style check #492

stevespringett opened this issue Jul 11, 2024 · 0 comments

Comments

@stevespringett
Copy link
Member

stevespringett commented Jul 11, 2024

The CycloneDX specification must have grammar and style checks. Ideally, checks would be performed:

  • On demand via GitHub Action
  • On PRs - fail if grammar or style violations occur

Grammar check should adhere to ISO House Style where British English is used to describe the specification, but is not required for the specification itself. The ISO House Style also requires American English for certain words with Greek origin (e.g. standardization - with a 'z' not an 's').

Acceptance criteria:

  • Scoped to JSON Schema only. Checks for XML and Protobuf are optional and nice-to-have.

  • Schema properties

    • American English spell check on property names
    • Enforce lower camel case on property names
  • Property titles:

    • Titles must be sentence case
    • British English (ISO House Style) spell check enforced
  • Property descriptions (description and meta:enum)

    • Descriptions must be sentence case
    • Descriptions must form at least one complete sentence
    • Descriptions must end in a single full-stop (.)
    • British English (ISO House Style) spell check enforced
    • Grammar check
    • Ensure RFC-2119 style capitalization of MUST, SHOULD, etc are NOT used in descriptions
  • Enumeration values

    • TODO: Define

Experiments

I have been experimenting with spelling and grammar checks with GitHub Actions in my personal repo. See
https://github.com/stevespringett/jsonschema-grammar-action and https://github.com/stevespringett/jsonschema-grammar-action/tree/main/.github/workflows

References

The Ecma Rules for Editing and Distribution may be used as reference in addition to the ISO House Style.

@stevespringett stevespringett added this to the 1.7 milestone Jul 11, 2024
@stevespringett stevespringett changed the title Grammer and style check Grammar and style check Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant