Skip to content

Feat: Add support for different Node versions (NVM support) #1357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aryan-rajoria merged 27 commits into from
Sep 6, 2024
Merged

Feat: Add support for different Node versions (NVM support) #1357

aryan-rajoria merged 27 commits into from
Sep 6, 2024

Conversation

@aryan-rajoria
Copy link
Collaborator

@aryan-rajoria aryan-rajoria commented Sep 5, 2024 •
edited
Loading

This PR aims to add support to different Node.js versions, through -t nodejs<version>.
Tested on the following github repos:
For node-8:

    "https://github.com/kriasoft/react-app.git",
    "https://github.com/deepraining/blogs.git",

react-appbom.json
blogsbom.json

For node-10:

    "https://github.com/patrickjuchli/basic-ftp.git",
    "https://github.com/donavon/use-thwack.git",

basic-ftpbom.json
use-thwackbom.json

For node-12:

    "https://github.com/postcss/sugarss.git",
    "https://github.com/sindresorhus/pupa.git",

sugarssbom.json
pupabom.json

For node-14:

    "https://github.com/zabirauf/AutoGPT.js.git",
    "https://github.com/plexidev/quick.db.git",

AutoGPT.jsbom.json
quick.dbbom.json

For node-16:

    "https://github.com/Atome-FE/llama-node.git",
    "https://github.com/sindresorhus/react-extras.git",

llama-nodebom.json
react-extrasbom.json

For node-18:

    "https://github.com/glitch-soc/mastodon.git",
    "https://github.com/sindresorhus/element-ready.git"

mastodonbom.json
element-readybom.json

@aryan-rajoria
Copy link
Collaborator Author

aryan-rajoria commented Sep 5, 2024

For the dvna project:
https://github.com/appsecco/dvna.git
sbom generated using args:

"args": [
                "-t",
                "nodejs8",
                "-o",
                "~/dvnasbom.json",
                "~/dvna"
            ]

dvnasbom.json

@aryan-rajoria aryan-rajoria changed the title Feat: Add support for Different Node versions (NVM support) Feat: Add support for different Node versions (NVM support) Sep 5, 2024
prabhu
prabhu reviewed Sep 5, 2024
View reviewed changes
prabhu
prabhu reviewed Sep 5, 2024
View reviewed changes
prabhu
prabhu reviewed Sep 5, 2024
View reviewed changes
prabhu
prabhu reviewed Sep 5, 2024
View reviewed changes
prabhu
prabhu reviewed Sep 5, 2024
View reviewed changes
@aryan-rajoria
Copy link
Collaborator Author

aryan-rajoria commented Sep 5, 2024

For node-20:

    "https://github.com/nowsecure/node-applesign.git",
    "https://github.com/Mojang/minecraft-scripting-libraries.git",

node-applesignbom.json
minecraft-scripting-librariesbom.json

For node-22:

    "https://github.com/DIYgod/RSSHub.git",
    "https://github.com/pex-gl/pex-gl.git",

RSSHubbom.json
pex-glbom.json

github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 5, 2024
View reviewed changes
@aryan-rajoria
add nvm tool support functions
bf1fcf8 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
added all required functions
5b90e61 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
bug fixes
8bd6e85 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
add nodejs<version> project alias
3c425cd 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
add nodejs version supported to project type alias
312afaf 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
run gen-types
cbcc0fb 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
run lint
584d661 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
applied reviewed changes
fd7d57c 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
advanced security warning fixed
3955544 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
rerun gen types
a130a92 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria aryan-rajoria marked this pull request as ready for review September 5, 2024 17:18
@aryan-rajoria aryan-rajoria force-pushed the nvm-support branch 2 times, most recently from 611ec25 to a130a92 Compare September 5, 2024 17:19
@aryan-rajoria
run lint
cdf79e4 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
Copy link
Collaborator Author

aryan-rajoria commented Sep 5, 2024

reran for all versions of node
mastodonbom.json
minecraft-scripting-librariesbom.json
node-applesignbom.json
pex-glbom.json
pupabom.json
quick.dbbom.json
react-appbom.json
react-extrasbom.json
RSSHubbom.json
sugarssbom.json
use-thwackbom.json
AutoGPT.jsbom.json
basic-ftpbom.json
blogsbom.json
element-readybom.json
llama-nodebom.json

@aryan-rajoria
remove comment
a7cb70b 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
add repotests
fc05ca7 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
fix indentation error
eba7db7 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
added ref for all new repotests
fa0a9b5 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
fix repotests
40c07c1 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
remove refs
6e3cb3b 
Signed-off-by: Aryan Rajoria <[email protected]>
prabhu
prabhu reviewed Sep 6, 2024
View reviewed changes
prabhu
prabhu reviewed Sep 6, 2024
View reviewed changes
prabhu
prabhu reviewed Sep 6, 2024
View reviewed changes
@aryan-rajoria
fix directoryPath
643f801 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
lint
cb12745 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
debug nvm ci
05359be 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
debug remove unused import
64f8e9e 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
debug bug fix
432b35b 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
debug add nvm and rearrange repotests
5e4c0eb 
Signed-off-by: Aryan Rajoria <[email protected]>
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 6, 2024
View reviewed changes
pregen.js
Comment on lines +211 to +227
const resultNpmInstall = spawnSync(
process.env.SHELL || "bash",
[
"-i",
"-c",
`export PATH='${nvmNodePath}${delimiter}$PATH' && npm install --package-lock-only`,
],
{
encoding: "utf-8",
shell: process.env.SHELL || true,
cwd: filePath,
env: {
...process.env,
PATH: newPath,
},
},
);

Check warning

Code scanning / CodeQL

Shell command built from environment values

This shell command depends on an uncontrolled [file name](1).
@aryan-rajoria
add early return
79da7e7 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
remove directory list
8ba60d9 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
run gen-types
622223b 
Signed-off-by: Aryan Rajoria <[email protected]>
prabhu
prabhu reviewed Sep 6, 2024
View reviewed changes
prabhu
prabhu reviewed Sep 6, 2024
View reviewed changes
prabhu
prabhu reviewed Sep 6, 2024
View reviewed changes
@aryan-rajoria
add suggested changes
57df0b7 
Signed-off-by: Aryan Rajoria <[email protected]>
prabhu
prabhu reviewed Sep 6, 2024
View reviewed changes
pregen.js
export function tryLoadNvmAndInstallTool(nodeVersion) {
const NVM_DIR = process.env.NVM_DIR;

const command = `
Copy link
Collaborator

@prabhu prabhu Sep 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok for this PR, but this won't work in Windows powershell. Maybe this could be added in another PR.

@prabhu
Copy link
Collaborator

prabhu commented Sep 6, 2024

Great job on your first sponsored PR! Just a couple of rename suggestions.

@aryan-rajoria aryan-rajoria merged commit f1a60cd into master Sep 6, 2024
@aryan-rajoria aryan-rajoria deleted the nvm-support branch September 6, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prabhu prabhu prabhu approved these changes

Assignees

No one assigned

Labels

lang:node sponsored

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aryan-rajoria @prabhu