-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does xxhsum utility support xxh3 (64bit)? #447
Comments
This feature is currently not exposed, |
Formally it has resolved my issue, but I'm not sure if I should close it, because if I do, I will open new with similar content, but with accent on "please implement this 🥺". |
It's not because something can be implemented that it should be implemented. |
I think exposing xxh3 64 bit to Maybe something like, On a side-note: I'm a brand new user of xxHash, and assumed on first use that |
We may have a way to do that by using the BSD output format, which explicitly states the hash used (rather than implying it based on the hash length). |
Yeah, the options I see are this:
|
my +1 for:
it took me some time to figure out why the hashing is so slower |
Whatever the consensus will be, I urge you to bear in mind the notorious fate of confusing Blake2 flavours (b, s, bp, sp), which is why the subsequent release of Blake3 in a single, outperforming flavour brought a great relief to the community. People around the world develop various digest calculators as we speak and often they embed everything that can be embedded to boast “my app is that powerful” regardless of the actual tasks to be solved, which creates a paralyzing quagmire of abundance “what algo to choose”. So right now at the design stage it is important to lay down an understanding of what needs this or that option is for. That is, if XXH3_64 outperforms XXH64 and it surely does, then let’s endorse the former as a new default and gradually eliminate the latter from circulation before it’s not spread that much in the wild. |
That being said, we have in this thread a few suggestions on how it could be done while reducing sensibly risks of confusion. |
I just tried to modify xxhsum so I could produce test vectors for XXH3_64bits. There are some parts of it that seem to be too difficult to hack already because of its reliance on digest length. Maybe it's time to introduce a new tool with more properly designed options and overhauled code, and then perhaps name it xxhsum2 or xxh.
Also maybe it's time to make naming of the new algorithms more formal (and strict) in all parts of the code and all discussions to lessen the confusion. Like maybe always call XXH3 as XXH3_64bits (or xxh3-64), and XXH128 as XXH_128bits (or xxh3-128). |
Just in case anyone's interested, I created a patch to make XXH3_64bits work in xxhsum: https://github.com/konsolebox/digest-xxhash-ruby/blob/master/test/xxhsum.c.c0e86bc0.diff This also allows secrets to be entered. |
|
xxhsum definitely supports xxh3_128bit, but I didn't find support of 64 variant there, this is seems wierd for me, is the man lagging behind the actual features or is it a really missing one?
The text was updated successfully, but these errors were encountered: