Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write examples with larger arrays #13

Open
riking opened this issue Jun 6, 2023 · 1 comment
Open

Write examples with larger arrays #13

riking opened this issue Jun 6, 2023 · 1 comment

Comments

@riking
Copy link

riking commented Jun 6, 2023

All of the array sizes in the documentation examples seem to be fairly small: the element type is always bytes, and the size is never more than about 5. I think that an example of hash function round constants would be more compelling, such as the data found here:

https://github.com/jedisct1/rust-hmac-sha256/blob/e787a2e40ce00c7e27b336207cdec730226ff6f1/src/lib.rs#L127-L138

Here, the program needs 64 u32s and loads (up to) 16 at a time.

Motivated via rust-lang/rust#109000.

@Cryptjar
Copy link
Owner

Cryptjar commented Jun 9, 2023

Certainly, a more elaborate example would be a welcome addition. Tho, an entire HMAC implementation seems a bit excessive.
If you have a good idea for an example with a more 'practical' array demonstration that isn't worth an entire crate on its own, I would gladly accept your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants