From cf2cc3ebd392926f06b7612a49b432b1138bf3df Mon Sep 17 00:00:00 2001 From: Joana Maia Date: Thu, 12 Dec 2024 12:03:17 +0000 Subject: [PATCH] Fix event payload with empty key --- .../src/modules/member/components/member-merge-suggestions.vue | 2 +- .../suggestions/filters/merge-suggestions-confidence-filter.vue | 2 ++ .../suggestions/filters/merge-suggestions-projects-filter.vue | 2 ++ .../components/suggestions/filters/merge-suggestions-search.vue | 2 ++ frontend/src/shared/modules/filters/components/Filter.vue | 2 +- frontend/src/shared/modules/filters/components/FilterSearch.vue | 2 +- frontend/src/shared/modules/monitoring/types/event.ts | 2 ++ 7 files changed, 11 insertions(+), 3 deletions(-) diff --git a/frontend/src/modules/member/components/member-merge-suggestions.vue b/frontend/src/modules/member/components/member-merge-suggestions.vue index e68e3b66c8..0d717b1fb6 100644 --- a/frontend/src/modules/member/components/member-merge-suggestions.vue +++ b/frontend/src/modules/member/components/member-merge-suggestions.vue @@ -285,7 +285,7 @@ const mergeSuggestion = () => { loadingMessage(); trackEvent({ - key: FeatureEventKey.MERGE_MEMBERS_MERGE_SUGGESTION, + key: FeatureEventKey.MERGE_MEMBER_MERGE_SUGGESTION, type: EventType.FEATURE, properties: { similarity: membersToMerge.value.similarity, diff --git a/frontend/src/modules/member/components/suggestions/filters/merge-suggestions-confidence-filter.vue b/frontend/src/modules/member/components/suggestions/filters/merge-suggestions-confidence-filter.vue index 039490b3a4..46ef6f18fc 100644 --- a/frontend/src/modules/member/components/suggestions/filters/merge-suggestions-confidence-filter.vue +++ b/frontend/src/modules/member/components/suggestions/filters/merge-suggestions-confidence-filter.vue @@ -93,6 +93,8 @@ const apply = () => { key = FeatureEventKey.FILTER_MEMBERS_MERGE_SUGGESTIONS; } else if (routeName === 'organizationMergeSuggestions') { key = FeatureEventKey.FILTER_ORGANIZATIONS_MERGE_SUGGESTIONS; + } else { + key = FeatureEventKey.FILTER; } if (key) { diff --git a/frontend/src/modules/member/components/suggestions/filters/merge-suggestions-projects-filter.vue b/frontend/src/modules/member/components/suggestions/filters/merge-suggestions-projects-filter.vue index 18e91218d2..1b11d30de2 100644 --- a/frontend/src/modules/member/components/suggestions/filters/merge-suggestions-projects-filter.vue +++ b/frontend/src/modules/member/components/suggestions/filters/merge-suggestions-projects-filter.vue @@ -198,6 +198,8 @@ const apply = () => { key = FeatureEventKey.FILTER_MEMBERS_MERGE_SUGGESTIONS; } else if (routeName === 'organizationMergeSuggestions') { key = FeatureEventKey.FILTER_ORGANIZATIONS_MERGE_SUGGESTIONS; + } else { + key = FeatureEventKey.FILTER; } if (key) { diff --git a/frontend/src/modules/member/components/suggestions/filters/merge-suggestions-search.vue b/frontend/src/modules/member/components/suggestions/filters/merge-suggestions-search.vue index 771bebe301..72af73f84a 100644 --- a/frontend/src/modules/member/components/suggestions/filters/merge-suggestions-search.vue +++ b/frontend/src/modules/member/components/suggestions/filters/merge-suggestions-search.vue @@ -40,6 +40,8 @@ const search = (val: string) => { key = FeatureEventKey.SEARCH_MEMBERS_MERGE_SUGGESTIONS; } else if (routeName === 'organizationMergeSuggestions') { key = FeatureEventKey.SEARCH_ORGANIZATIONS_MERGE_SUGGESTIONS; + } else { + key = FeatureEventKey.SEARCH; } if (key) { diff --git a/frontend/src/shared/modules/filters/components/Filter.vue b/frontend/src/shared/modules/filters/components/Filter.vue index c40de09d2b..4d3359cfd0 100644 --- a/frontend/src/shared/modules/filters/components/Filter.vue +++ b/frontend/src/shared/modules/filters/components/Filter.vue @@ -165,7 +165,7 @@ watch( } else if (routeName === 'activity' && routeHash === '#conversation') { key = FeatureEventKey.FILTER_CONVERSATIONS; } else { - key = null; + key = FeatureEventKey.FILTER; } if (key) { diff --git a/frontend/src/shared/modules/filters/components/FilterSearch.vue b/frontend/src/shared/modules/filters/components/FilterSearch.vue index daec3e8b87..f4d304f233 100644 --- a/frontend/src/shared/modules/filters/components/FilterSearch.vue +++ b/frontend/src/shared/modules/filters/components/FilterSearch.vue @@ -63,7 +63,7 @@ const changeValue = debounce((search: string) => { } else if (routeName === 'activity' && routeHash === '#conversation') { key = FeatureEventKey.SEARCH_CONVERSATIONS; } else { - key = null; + key = FeatureEventKey.SEARCH; } if (key) { diff --git a/frontend/src/shared/modules/monitoring/types/event.ts b/frontend/src/shared/modules/monitoring/types/event.ts index c9cfecaa7c..ecf104dc56 100644 --- a/frontend/src/shared/modules/monitoring/types/event.ts +++ b/frontend/src/shared/modules/monitoring/types/event.ts @@ -135,4 +135,6 @@ export enum FeatureEventKey { SELECT_PROJECT_GROUP = 'Select project group', FILTER_DASHBOARD = 'Filter dashboard', COPILOT_REVIEW_PROFILE = 'Copilot review profile', + SEARCH = 'Search', + FILTER = 'Filter', }