Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

before_handler on middlewares not called for OPTIONS requests #967

Open
CircuitCoder opened this issue Jan 1, 2025 · 0 comments
Open

before_handler on middlewares not called for OPTIONS requests #967

CircuitCoder opened this issue Jan 1, 2025 · 0 comments
Labels
question Issue can be closed by providing information

Comments

@CircuitCoder
Copy link

before_handler seems to not be invoked during OPTIONS requests.

We're upgrading from an very old version of crow (>6 years old) which was before CORSHandler came into existence, so we had to handle CORS headers ourselves. We did this by adding these headers in the before_handler, which is not effective after the upgrade.

I'm reading crow's code, but haven't been able to find out what caused this behavior. Is this the intended behavior?

Thank you.
@gittiver gittiver added the question Issue can be closed by providing information label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Issue can be closed by providing information
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gittiver @CircuitCoder