Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drone build for PRs is hanging #581

Closed
gittiver opened this issue Dec 25, 2022 · 6 comments
Closed

Drone build for PRs is hanging #581

gittiver opened this issue Dec 25, 2022 · 6 comments
Labels
task Non code related issue

Comments

@gittiver
Copy link
Member

Hi,

the drone build used as check on PR's seems to hang.
See this Pul Request: #580

@The-EDev The-EDev added the task Non code related issue label Dec 25, 2022
@The-EDev
Copy link
Member

I've been trying to figure out what's going wrong with this for a while now, I have no idea what's causing it...

@gittiver
Copy link
Member Author

what about using GitHub actions for building, testing and generating gh pages?

@The-EDev
Copy link
Member

I've looked at actions when travis changed their structure. I ultimately decided against it because of the point system and it being a closed source system that cannot be self hosted.

I've been looking into hosting drone myself, and I think it's doable. the only disadvantage is that ARM testing will have to be dropped for the time being I believe.

@gittiver
Copy link
Member Author

drone.io is also changing into an at least only open core model. gh actions means always running checks without efforts to maintain the CI itself.
I mean, there is a simple, small PR which seems blocked, because of not running checks/ problems with drone.
The actions could be activated by a few configuration files and bam, there would be a proof that a changed PR is working.

I could provide adapted action for building in a PR, should I?

@The-EDev
Copy link
Member

@gittiver Thanks a lot for adding github actions support to Crow! I'm guessing this issue should be closed now. Please let me know if it needs to stay open.

@gittiver
Copy link
Member Author

No, can be closed. Only Windows build is not yet supported on GitHub actions. but this is a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Non code related issue
Projects
None yet
Development

No branches or pull requests

2 participants