Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPTIONS response without content-length #402

Closed
jeanbiber opened this issue Apr 11, 2022 · 2 comments · Fixed by #424
Closed

OPTIONS response without content-length #402

jeanbiber opened this issue Apr 11, 2022 · 2 comments · Fixed by #424
Labels
bug Something isn't working
Milestone
v1.0+2 Hotfix

Comments

@jeanbiber
Copy link

The OPTIONS response doesn't contain a content-length field. I think that the response must include a Content-Length field with a value of 0.
@jeanbiber
Copy link
Author

If I set "res.manual_length_header = false;" (routing.h Line 1489) it works for me but I am not sure if it's the right solution for this issue.

@The-EDev
Copy link
Member

Confirmed. According to RFC2616 section 9.2:

the response MUST include a Content-Length field with a field-value of "0".

Thank you @jeanbiber for reporting this issue.

@The-EDev The-EDev added the bug Something isn't working label Apr 11, 2022
@The-EDev The-EDev added this to the v1.0+2 Hotfix milestone Apr 25, 2022
@The-EDev The-EDev mentioned this issue Apr 27, 2022
Merged
@The-EDev The-EDev mentioned this issue Apr 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v1.0+2 Hotfix
Development

Successfully merging a pull request may close this issue.

Multiple small changes CrowCpp/Crow
2 participants
@The-EDev @jeanbiber