Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved control of Content-Type relating to page.render() #313

Closed
arnholm opened this issue Jan 4, 2022 · 0 comments · Fixed by #346
Closed

Improved control of Content-Type relating to page.render() #313

arnholm opened this issue Jan 4, 2022 · 0 comments · Fixed by #346
Labels
feature Code based project improvement
Milestone

Comments

@arnholm
Copy link

arnholm commented Jan 4, 2022

With reference to #310 and page.render() it is observed that page.render() returns a simple string and when used with a CROW_ROUTE's return, it will not properly set the Content-Type header to text/html.

It would probably be worth adding 2 rendering methods, one that returns a string and another that returns a crow::returnable object.

@The-EDev The-EDev added feature Code based project improvement good first issue an issue suitable to start contributing to the project labels Jan 4, 2022
@The-EDev The-EDev removed the good first issue an issue suitable to start contributing to the project label Feb 10, 2022
@The-EDev The-EDev added this to the v1.0 milestone Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Code based project improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants