Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST_CASE("stream_response") doesn't work most of the time. #233

Closed
The-EDev opened this issue Oct 1, 2021 · 1 comment · Fixed by #234
Closed

TEST_CASE("stream_response") doesn't work most of the time. #233

The-EDev opened this issue Oct 1, 2021 · 1 comment · Fixed by #234
Labels
bug Something isn't working

Comments

@The-EDev
Copy link
Member

The-EDev commented Oct 1, 2021

asio::ip::tcp::socket::receive() does not guarantee that the entire buffer size is received. The test doesn't take that into account, which sometimes causes data to be missing thus failing the test.

@The-EDev The-EDev added the bug Something isn't working label Oct 1, 2021
@The-EDev The-EDev changed the title TEST_CASE("stream_response") doesn't account for when not the entire buffer is received TEST_CASE("stream_response") doesn't Work most of the time. Oct 5, 2021
@The-EDev
Copy link
Member Author

The-EDev commented Oct 5, 2021

Update: it seems that the test case does try to account for the buffer size. Something else seems to be causing this error, maybe the fact that the line consuming the headers doesn't?

Unfortunately it is damn near impossible to properly debug this issue since it only happens on CI.

@The-EDev The-EDev changed the title TEST_CASE("stream_response") doesn't Work most of the time. TEST_CASE("stream_response") doesn't work most of the time. Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant