From d4f7df87399c8c73da9b1bf76b70482709a6286a Mon Sep 17 00:00:00 2001 From: Matt Ellis Date: Wed, 7 Jun 2023 15:47:24 -0700 Subject: [PATCH] Remove wait associated with Experiment start summary (#298) Remove the wait associated with the Experiment start summary. [ committed by @mellis13 ] [ reviewed by @billschereriii ] --- doc/changelog.rst | 3 +++ smartsim/experiment.py | 12 ------------ 2 files changed, 3 insertions(+), 12 deletions(-) diff --git a/doc/changelog.rst b/doc/changelog.rst index c42f76465..c8151ef3f 100644 --- a/doc/changelog.rst +++ b/doc/changelog.rst @@ -25,6 +25,7 @@ Description A full list of changes and detailed notes can be found below: +- Remove wait time associated with Experiment launch summary - Update and rename Redis conf file - Migrate from redis-py-cluster to redis-py - Update full test suite to not require a TF wheel at test time @@ -36,6 +37,7 @@ A full list of changes and detailed notes can be found below: Detailed notes +- Remove wait time associated with Experiment launch summary (PR298_) - Update Redis conf file to conform with Redis v7.0.5 conf file (PR293_) - Migrate from redis-py-cluster to redis-py for cluster status checks (PR292_) - Update full test suite to no longer require a tensorflow wheel to be available @@ -51,6 +53,7 @@ codes. These have now all been updated. (PR284_) - Orchestrator and Colocated DB now accept a list of interfaces to bind to. The argument name is still `interface` for backward compatibility reasons. (PR281_) +.. _PR298: https://github.com/CrayLabs/SmartSim/pull/298 .. _PR293: https://github.com/CrayLabs/SmartSim/pull/293 .. _PR292: https://github.com/CrayLabs/SmartSim/pull/292 .. _PR291: https://github.com/CrayLabs/SmartSim/pull/291 diff --git a/smartsim/experiment.py b/smartsim/experiment.py index dda2e8ba5..ba5c17c09 100644 --- a/smartsim/experiment.py +++ b/smartsim/experiment.py @@ -814,17 +814,5 @@ def _launch_summary(self, manifest): logger.info(summary) - wait, steps = 10, 100 - prog_bar = trange( - steps, - desc="Launching in...", - leave=False, - ncols=80, - mininterval=0.25, - bar_format="{desc}: {bar}| {remaining} {elapsed}", - ) - for _ in prog_bar: - time.sleep(wait / steps) - def __str__(self): return self.name