Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reducer methods without EventContext are not discovered #1435

Open
einari opened this issue Sep 24, 2024 · 0 comments
Open

Reducer methods without EventContext are not discovered #1435

einari opened this issue Sep 24, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@einari
Copy link
Contributor

einari commented Sep 24, 2024

The attribute NullableAttribute is missing from the second parameter if we don't have the third EventContext parameter. This result in the code not accepting it as a reducer method, because it is expecting it to be nullable if the declaring type is in a nullable context. The IsNullableReferenceType() comes from Fundamentals, not sure if it needs to be more clever or something.

@einari einari added the bug Something isn't working label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant