Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing Godot does not warn about pending changes to orchestrations #721

Open
dschiller opened this issue Aug 11, 2024 · 2 comments
Open
Labels
bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 cherrypick:2.1 Requires cherry-pick to Orchestrator 2.1 kind/bug A bug or regression in expected behavior.
Milestone

Comments

@dschiller
Copy link

dschiller commented Aug 11, 2024

Describe the bug

When changing a EventGraph and quitting Godot there is no warning for unsaved data. Also there is no asterisk "somewhere" to mark the EventGraph as changed. When reopening the Project the changes done in the EventGraph are lost.

Expected behavior

Change any EventGraph should inform the user with an asterisk about unsaved data changes. Also Godot should not quit when EventGraph's are "dirty" (unsaved).

Actual behavior

Changing a EventGraph and quitting Godot does not warn nor save the changes.

How to Reproduce?

  1. Open a Project with a EventGraph
  2. Change the EventGraph
  3. Quit Godot
  4. Reopen the Project >> Changes are gone

Godot full version

4.3.rc3

Orchestrator version

2.1.rc4

Additional information

No response

@dschiller dschiller added the kind/bug A bug or regression in expected behavior. label Aug 11, 2024
@Naros Naros added bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 cherrypick:2.1 Requires cherry-pick to Orchestrator 2.1 labels Aug 11, 2024
@Naros Naros added this to the 2.2 milestone Aug 11, 2024
@Naros
Copy link
Member

Naros commented Aug 12, 2024

The main issue is that there is no universal way to track Resource::is_edited since that isn't exposed to GDExtension. I have an open PR in the upstream Godot to add this, which I believe they delayed until Godot 4.4. :(

@dschiller
Copy link
Author

Could you invalidate any other file / resource ? Maybe the one that the Orchestrator script is assigned to ?

@Naros Naros changed the title Data loss Closing Godot does not warn about pending changes to orchestrations Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 cherrypick:2.1 Requires cherry-pick to Orchestrator 2.1 kind/bug A bug or regression in expected behavior.
Projects
None yet
Development

No branches or pull requests

2 participants