Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable export plugin to remap Orchestrations to binary format #695

Open
Naros opened this issue Aug 10, 2024 · 0 comments
Open

Re-enable export plugin to remap Orchestrations to binary format #695

Naros opened this issue Aug 10, 2024 · 0 comments
Labels
bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 cherrypick:2.1 Requires cherry-pick to Orchestrator 2.1 kind/bug A bug or regression in expected behavior.
Milestone

Comments

@Naros
Copy link
Member

Naros commented Aug 10, 2024

Describe the bug

In GH-693, the export plug-in was disabled due to an issue with translating .torch files to .os files.

The underlying problem is that Orchestrator relies on a post-initialize step that amends the loaded resource state with some transient state that influences specific behaviors for certain nodes. In the case of GH-693, this was the resolution of the _chainable member variable.

Since the export plugin does not perform this post-initialize step, transient state is missing when the exporter writes the binary data to the target remap file, and so some properties for nodes are not being correctly serialized. In the case of _chainable, this causes the binary remap file to mark the node as not-chained, and this causes the Orchestration to behave differently than what is observed in the editor.

Expected behavior

There should be no change in behavior.

Actual behavior

No response

How to Reproduce?

No response

Godot full version

No response

Orchestrator version

2.0.rc3 / 2.1.rc4

Additional information

We need to test and see what problems, if any, could result from performing the post-initialize step during the export plugin's stage where .torch files are converted to binary format. If there are issues, then we nee to re-evaluate transient state entirely.

@Naros Naros added kind/bug A bug or regression in expected behavior. bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 cherrypick:2.1 Requires cherry-pick to Orchestrator 2.1 labels Aug 10, 2024
@Naros Naros added this to the 2.2 milestone Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 cherrypick:2.1 Requires cherry-pick to Orchestrator 2.1 kind/bug A bug or regression in expected behavior.
Projects
None yet
Development

No branches or pull requests

1 participant