-
Notifications
You must be signed in to change notification settings - Fork 972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fixes for China] Google Maps in Geolocations #183
Comments
Hi, could someone first fix the jquery cdn issue? That is top priority for us. |
What issue are you referring to? |
Hi, I think @tianshuo is referring to the fact that javascript file for the map is loaded from a CDN. Unfortunately the fix for this is not hosting the file locally. Google doesn't allow this and even if we can host it locally the script will still make calls to Google servers. We started changing the world visualisation to DataMaps and will find a similar fix for push geolocations as well. Sorry for the inconvenience and thanks for your patience! |
I'm working on echarts of Baidu. |
I created a new issue ( #211 ) for what I mentioned previously. |
@jianglinchun did you have any chance to complete eCharts support? |
@osoner I'm busy with my jobs now. And I'd successfully developed a new plugin which used echarts. I may submit the pull requests within 1-2 month. |
@osoner I had fix the problem. But I'm not sure UE and the code guideline. Or should I and a switch to the config? |
@jianglinchun can we have a skype telco for this if you are done with your plugin? :) That would be really great if we can come up with a solution that can be used for China, and include it in next release if you are also comfortable with that. Awaiting for your reply. |
@gorkem-cetin thank you for your attention. I'd checkout the latest countly branch and I found a google service switch was added to the config panel. So I thought I should modify my code and use the switch value to decide when to switch to echarts. |
That exactly would work like that, unless @ar2rsawseen has another idea. |
Yes, the check for setting is actually quite simple: |
please check this pull request: |
Please use the solution from baidu officially. http://lbsyun.baidu.com/index.php?title=open/move |
Well, the issue is obvious. Google Maps doesn't work in China so geolocations doesn't work either. Not really sure how to proceed here, Bing Maps? or configurable Baidu Maps option @iartem?
The text was updated successfully, but these errors were encountered: