Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes for China] Google Maps in Geolocations #183

Closed
osoner opened this issue Aug 21, 2015 · 14 comments
Closed

[Fixes for China] Google Maps in Geolocations #183

osoner opened this issue Aug 21, 2015 · 14 comments
Assignees

Comments

@osoner
Copy link
Member

osoner commented Aug 21, 2015

Well, the issue is obvious. Google Maps doesn't work in China so geolocations doesn't work either. Not really sure how to proceed here, Bing Maps? or configurable Baidu Maps option @iartem?

image

@tianshuo
Copy link

tianshuo commented Nov 6, 2015

Hi, could someone first fix the jquery cdn issue? That is top priority for us.

@iartem
Copy link
Contributor

iartem commented Nov 6, 2015

What issue are you referring to?

@osoner
Copy link
Member Author

osoner commented Nov 6, 2015

Hi, I think @tianshuo is referring to the fact that javascript file for the map is loaded from a CDN. Unfortunately the fix for this is not hosting the file locally. Google doesn't allow this and even if we can host it locally the script will still make calls to Google servers.

We started changing the world visualisation to DataMaps and will find a similar fix for push geolocations as well.

Sorry for the inconvenience and thanks for your patience!

@jianglinchun
Copy link

I'm working on echarts of Baidu.
http://echarts.baidu.com/doc/example/map1.html
http://echarts.baidu.com/doc/example/map4.html
I'll share the code ASAP.

@tianshuo
Copy link

I created a new issue ( #211 ) for what I mentioned previously.
If provinces in China is supported, that would be great.

@osoner
Copy link
Member Author

osoner commented Jan 13, 2016

@jianglinchun did you have any chance to complete eCharts support?

@jianglinchun
Copy link

@osoner I'm busy with my jobs now. And I'd successfully developed a new plugin which used echarts. I may submit the pull requests within 1-2 month.

@jianglinchun
Copy link

@osoner I had fix the problem. But I'm not sure UE and the code guideline. Or should I and a switch to the config?

@gorkem-cetin
Copy link
Contributor

@jianglinchun can we have a skype telco for this if you are done with your plugin? :) That would be really great if we can come up with a solution that can be used for China, and include it in next release if you are also comfortable with that.

Awaiting for your reply.

@jianglinchun
Copy link

@gorkem-cetin thank you for your attention. I'd checkout the latest countly branch and I found a google service switch was added to the config panel. So I thought I should modify my code and use the switch value to decide when to switch to echarts.
And my skype id: [email protected] :)

@gorkem-cetin
Copy link
Contributor

That exactly would work like that, unless @ar2rsawseen has another idea.

@ar2rsawseen
Copy link
Member

@jianglinchun
Copy link

please check this pull request:
#273

@jianglinchun
Copy link

Please use the solution from baidu officially. http://lbsyun.baidu.com/index.php?title=open/move

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants