Circular dependencies need to be fixed

[AndrewFarley]

Because there are circular dependancies there is memory leaks and constantly increasing memory usage of Next.js. After some research this appears to be related to and/or because of..

vercel/next.js#34659
nodejs/node#42080

I used an wonderful tool to help figure this out called madge and ran it with the following command...

npx madge   -c --extensions ts,tsx --exclude "test*" -l dot --dot  -i test.png ./

Which outputs the file explaining the circular dependencies...

I might also recommend to after fixing our circular deps, to integrate this tool into our testing and to basically fail out and don't let new code with circular dependencies to be merged into master.

[darrenvong]

Is this actually happening in production? Hot reload should not be enabled/used in production as it's mainly for fast feedback during development when we change some code. It creates some impossible scenarios like loading modules multiple times and so we may be better off disabling that first, then fix the circular imports.

[AndrewFarley]

Because we no longer use dependencies/modules in production I'm going to close this. Can re-open at a later time if needed.