Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save Directory Error #85

Closed
perrinaz opened this issue May 16, 2019 · 3 comments
Closed

Save Directory Error #85

perrinaz opened this issue May 16, 2019 · 3 comments

Comments

@perrinaz
Copy link

When a directory is specified, say "D:\Downloads\Comixology" the addon appends a forward slash (/) and no files are saved. The error given when "collect errors" is turned on is "Invalid Filename" and "onend" is not a function.

@perrinaz
Copy link
Author

I do not know if this is still being maintained so I'll add this for anybody who experienced the same issues I did. Basically, the directory option takes a single sub-directory that will be created in the Chrome downloads directory. It does not accept any pathing (that I've been able to discover) so no absolute paths like I tried or even ..\path type directories.

@Cortys
Copy link
Owner

Cortys commented Nov 4, 2019

@perrinaz Thanks for reporting this. I currently don't have the time to maintain the project but I plan to properly deal with the currently open issues in the future.

The problem you describe is due to Chrome's security policy and cannot really be solved. I'll keep this open anyway as a reminder to add input validation to the download directory option so that absolute paths are rejected with a clear error message.

@Cortys
Copy link
Owner

Cortys commented Aug 4, 2021

Finally addressed this in the 2.4.1 release by providing a proper error message on invalid paths.

@Cortys Cortys closed this as completed Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants