Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we support env var and yaml versions of short name cli options? #824

Open
siladu opened this issue Jun 27, 2023 · 0 comments
Open
Labels
TeamCerberus Under active development by TeamCerberus @Consensys

Comments

@siladu
Copy link
Contributor

siladu commented Jun 27, 2023

The status quo is confusing. W3S kind of half supports them: https://github.com/ConsenSys/web3signer/blob/master/commandline/src/main/java/tech/pegasys/web3signer/commandline/valueprovider/EnvironmentVariableDefaultProvider.java#L36

If you have aliases of --logging, -l then only --logging will be supported.
But if you have one name of -l then it'll be supported.
I also think using longestName is a bug because --logging, --log, -l will only support --logging.

Similar question for YAML file support.

Besu explicitly filters out single dash prefixed options https://github.com/hyperledger/besu/blob/f43ae51d6f00984c8f87b67999f7a499987dbd49/besu/src/main/java/org/hyperledger/besu/cli/util/EnvironmentVariableDefaultProvider.java#L57-L58

@siladu siladu added the TeamCerberus Under active development by TeamCerberus @Consensys label Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TeamCerberus Under active development by TeamCerberus @Consensys
Projects
None yet
Development

No branches or pull requests

1 participant