Skip to content

update validation result for fee recipient mismatch to ignore instead of reject #10953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gfukushima merged 1 commit into from
Jul 9, 2026
+3 −3
Merged

update validation result for fee recipient mismatch to ignore instead of reject #10953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...java/tech/pegasys/teku/statetransition/validation/ExecutionPayloadBidGossipValidator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ public SafeFuture<InternalValidationResult> validate(
*/
if (!bid.getFeeRecipient().equals(proposerPreferences.get().getFeeRecipient())) {
return completedFuture(
reject(
ignore(
"Bid fee_recipient %s does not match proposer preferences fee_recipient %s",
bid.getFeeRecipient(), proposerPreferences.get().getFeeRecipient()));
}
Expand Down
4 changes: 2 additions & 2 deletions .../tech/pegasys/teku/statetransition/validation/ExecutionPayloadBidGossipValidatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,15 +163,15 @@ void shouldSaveForFuture_whenProposerPreferencesNotSeen() {
}

@TestTemplate
void shouldReject_whenFeeRecipientDoesNotMatchProposerPreferences() {
void shouldIgnore_whenFeeRecipientDoesNotMatchProposerPreferences() {
final ProposerPreferences mismatchedPreferences = mock(ProposerPreferences.class);
when(mismatchedPreferences.getFeeRecipient()).thenReturn(dataStructureUtil.randomEth1Address());
when(mismatchedPreferences.getTargetGasLimit()).thenReturn(bid.getGasLimit());
when(proposerPreferencesManager.getProposerPreferences(slot))
.thenReturn(Optional.of(mismatchedPreferences));

assertThatSafeFuture(bidValidator.validate(signedBid))
.isCompletedWithValueMatching(InternalValidationResult::isReject);
.isCompletedWithValueMatching(InternalValidationResult::isIgnore);
}

@TestTemplate
Expand Down
Loading