EIP-8045 + bump ref tests to v1.7.0-alpha.9 - #10766
Merged
Merged
Conversation
StefanBratanov
marked this pull request as draft
May 30, 2026 08:05
StefanBratanov
marked this pull request as ready for review
June 2, 2026 05:21
Contributor
|
we have a lot of reference tests for this, it will be covered |
StefanBratanov
changed the title
15 tasks
StefanBratanov
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Triplecrown411
approved these changes
Jun 2, 2026
zilm13
reviewed
Jun 2, 2026
|
|
||
| // modified to remove support for the former deposit mechanism | ||
| @Override | ||
| public boolean areEth1BridgeDepositsNotApplied( |
Contributor
There was a problem hiding this comment.
Is it "Not"? if it should be, I'd find another name for it, boolean with "not" is confusing
| # Constant for max value, defined elsewhere | ||
| - UINT64_MAX_SQRT | ||
| - EMPTY_BLOCK_HASH#bellatrix | ||
|
|
Contributor
Author
There was a problem hiding this comment.
this is part of Tuweni, on the other side we have MAX_SQRT, will do some changes
|
|
||
| # Not implemented: phase0 | ||
| - get_dependent_root#phase0 | ||
|
|
| # Not implemented: gloas | ||
| - get_proposer_dependent_root#gloas | ||
| - get_dependent_root#gloas | ||
|
|
| - get_payload_due_ms#gloas | ||
|
|
||
| # Will be fixed later phase0 and gloas | ||
| - get_supported_node#phase0 |
Contributor
There was a problem hiding this comment.
i mean what scope it fits better?
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Reviewed by Cursor Bugbot for commit ba9faf4. Configure here.
zilm13
enabled auto-merge (squash)
June 3, 2026 09:05
zilm13
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
ethereum/consensus-specs#5115
Also adds changes for ethereum/consensus-specs#4704 and new spec tests https://github.com/ethereum/consensus-specs/releases/tag/v1.7.0-alpha.9
Fixed Issue(s)
N/A
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Note
Medium Risk
Changes beacon-chain deposit processing, epoch pending-deposit ordering, and Gloas proposer selection鈥攃ore consensus paths鈥攖hough scoped to new fork milestones and accompanied by ref-test skips.
Overview
Bumps consensus reference tests to v1.7.0-alpha.9 and aligns Teku with new spec behavior, including EIP-8045 (Gloas proposer selection excludes slashed validators from the active pool before
compute_proposer_indices).Fulu now treats the legacy Eth1 deposit path as fully off:
isFormerDepositMechanismDisabledis always true, block bodies must have emptydeposits,processDepositsis a no-op, deposit requests no longer setdeposit_requests_start_index, and pending-deposit epoch processing no longer waits on Eth1 bridge deposits (ExecutionRequestsProcessorFulu/EpochProcessorFulu; Gloas builds on the Fulu processor). Electra retains the prior bridge/deposit-request semantics via shared helpers.Reference-test wiring drops
should_override_forkchoice_update, ignoresfork_choice/on_attestationand several new gossip suites (with targeted skips), expands gloas/altair/fulu exclusions, and skips one Fulu gossip beacon-block case. specrefs tracks alpha.9; fuzz deposit coverage moves to Electra because Fulu disables legacy deposits.Reviewed by Cursor Bugbot for commit 128e645. Bugbot is set up for automated code reviews on this repo. Configure here.