Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculate eip-165 interface ID #3

Closed
maurelian opened this issue May 8, 2018 · 5 comments
Closed

Calculate eip-165 interface ID #3

maurelian opened this issue May 8, 2018 · 5 comments

Comments

@maurelian
Copy link
Contributor

This should be a fairly straightforward addition?

Example algo for this:
ethereum/EIPs#165 (comment)
@GNSPS
Copy link
Collaborator

GNSPS commented May 9, 2018

Would this just be the calculation (like in here: https://github.com/ConsenSys/Tokens/pull/130/files#diff-b808593f56bf7fa165659c75633ff62cR38) or actually generating Solidity code like the one presented in the EIP?

@GNSPS
Copy link
Collaborator

GNSPS commented May 9, 2018

The latter would be much more laborious and as currently the Keccak hashing opcode, even if constant, is always resolved at runtime would also be more runtime costly. 😄

@maurelian
Copy link
Contributor Author

no no, the output would just be a 4 byte interface ID.

@maurelian
Copy link
Contributor Author

I wasn't sure if maybe it should be handled as a new module, or as a flag passed to describe?

Consider that I will probably make many such requests... so how to extend this thing rationally is important. :)

@maurelian
Copy link
Contributor Author

This is super low priority. Closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GNSPS @maurelian