Skip to content

fix: consolidate ResourceBounds sum #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 10, 2024
Merged

fix: consolidate ResourceBounds sum #456

merged 2 commits into from
Dec 10, 2024

Conversation

stanleyyconsensys
Copy link
Collaborator

This PR is to fix ResourceBounds that has not sum after estimate the fees

it include:

  • add helper class ConsolidateFees
  • sum resourceBounds with ConsolidateFees
  • re-work test to simplify mock estimate fees

@stanleyyconsensys stanleyyconsensys requested a review from a team as a code owner December 9, 2024 13:10
@stanleyyconsensys stanleyyconsensys requested review from Julink-eth and jonesho and removed request for a team December 9, 2024 13:10
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 9, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 9, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
4.5% Coverage on New Code
18.1% Duplication on New Code

See analysis details on SonarQube Cloud

khanti42
khanti42 approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@khanti42 khanti42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stanleyyconsensys stanleyyconsensys added this pull request to the merge queue Dec 10, 2024
Merged via the queue into main with commit 85ea8ba Dec 10, 2024
14 checks passed
@stanleyyconsensys stanleyyconsensys deleted the fix/consolidate-fee branch December 10, 2024 02:18
@github-actions github-actions bot mentioned this pull request Dec 10, 2024
Merged
@khanti42 khanti42 mentioned this pull request Jan 6, 2025
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khanti42 khanti42 khanti42 approved these changes

@Julink-eth Julink-eth Awaiting requested review from Julink-eth Julink-eth is a code owner automatically assigned from Consensys/snaps-factory-reviewers

@jonesho jonesho Awaiting requested review from jonesho jonesho is a code owner automatically assigned from Consensys/snaps-factory-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stanleyyconsensys @khanti42