Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(SNAP): add utils to manage snap ui #404

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

stanleyyconsensys
Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys commented Oct 24, 2024

This PR is to adding some utils method to manage the SNAP UI in a centralise file
to be more convenient when we need to replace with JSX component later

it create some reusable method to generate UI

  • rowUI : is to create a row component with text field
  • addressUI: is to create a row component with address and linked with explorer
  • networkUI: is to create a row component with default label Network
  • headerUI: is to create a heading component
  • dividerUI: is to create a divider component
  • signerUI: is to create a addressUI with default label Signer Address
  • jsonDataUI: is to create a row component with Json Serializer

@stanleyyconsensys stanleyyconsensys requested a review from a team as a code owner October 24, 2024 08:13
@stanleyyconsensys stanleyyconsensys requested review from Julink-eth and wantedsystem and removed request for a team October 24, 2024 08:13
@stanleyyconsensys stanleyyconsensys changed the title chore(SNAP): add utils to manage snap ui refactor(SNAP): add utils to manage snap ui Oct 24, 2024
Copy link

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
4.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@khanti42 khanti42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you very much for this change. Will make JSX implementation lot easier.

@stanleyyconsensys stanleyyconsensys added this pull request to the merge queue Oct 25, 2024
Merged via the queue into main with commit 90f94a5 Oct 25, 2024
16 checks passed
@stanleyyconsensys stanleyyconsensys deleted the chore/add-utils-for-snap-ui branch October 25, 2024 08:45
@github-actions github-actions bot mentioned this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants