Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(SNAP): fix incorrect params passed to SNAP RPCs #401

Merged
merged 1 commit into from
Oct 23, 2024
Merged

fix(SNAP): fix incorrect params passed to SNAP RPCs #401

merged 1 commit into from
Oct 23, 2024

Conversation

khanti42
Copy link
Collaborator

@khanti42 khanti42 commented Oct 22, 2024 •
edited by stanleyyconsensys
Loading

This PR is to fix the incorrect params passed to SNAP RPCs :

  • starkNet_signDeclareTransaction
  • starkNet_verifySignedMessage
  • starkNet_declareContract
  • starkNet_getDeploymentData

BEGIN_COMMIT_OVERRIDE
fix: Fix incorrect params passed to RPCs starkNet_signDeclareTransaction, starkNet_verifySignedMessage, starkNet_declareContract and starkNet_getDeploymentData (#401)
END_COMMIT_OVERRIDE

@khanti42 khanti42 requested a review from a team as a code owner October 22, 2024 13:26
@khanti42 khanti42 requested review from Akaryatrh and wantedsystem and removed request for a team October 22, 2024 13:26
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@khanti42 khanti42 mentioned this pull request Oct 22, 2024
Merged
@stanleyyconsensys stanleyyconsensys changed the title chore: fix missing access to requestParams in call to revamped rpc fix: Fix incorrect params in SNAP RPCs Oct 23, 2024
@stanleyyconsensys stanleyyconsensys changed the title fix: Fix incorrect params in SNAP RPCs fix(SNAP): Fix incorrect params in SNAP RPCs Oct 23, 2024
@stanleyyconsensys stanleyyconsensys changed the title fix(SNAP): Fix incorrect params in SNAP RPCs fix(SNAP): Fix incorrect params passed to SNAP RPCs Oct 23, 2024
@stanleyyconsensys stanleyyconsensys changed the title fix(SNAP): Fix incorrect params passed to SNAP RPCs fix(SNAP): fix incorrect params passed to SNAP RPCs Oct 23, 2024
@khanti42 khanti42 added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit a834beb Oct 23, 2024
21 checks passed
@khanti42 khanti42 deleted the chore/fix-revamped-execute-missing-requestparams branch October 23, 2024 07:09
@github-actions github-actions bot mentioned this pull request Oct 28, 2024
Merged
This was referenced Nov 26, 2024
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanleyyconsensys stanleyyconsensys stanleyyconsensys approved these changes

@Akaryatrh Akaryatrh Awaiting requested review from Akaryatrh Akaryatrh is a code owner automatically assigned from Consensys/snaps-factory-reviewers

@wantedsystem wantedsystem Awaiting requested review from wantedsystem wantedsystem is a code owner automatically assigned from Consensys/snaps-factory-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khanti42 @stanleyyconsensys