Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Snap): add RPC starkNet_getDeploymentData #381

Merged
merged 2 commits into from
Oct 17, 2024
Merged

feat(Snap): add RPC starkNet_getDeploymentData #381

merged 2 commits into from
Oct 17, 2024

Conversation

stanleyyconsensys
Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys commented Oct 17, 2024 •
edited
Loading

This PR is to add RPC starkNet_getDeploymentData into the snap

as it is designed for get-starknet v4

The purpose to have this API is to

  • having the checking to the account, where it should deployed / upgrade, and enforce the user to deployed / upgrade in our dapp
  • does not need to depulicate the deployment data in the snap and get-starkent

BEGIN_COMMIT_OVERRIDE
feat: Add new RPC starkNet_getDeploymentData to support get-starknet v4 (#381)
END_COMMIT_OVERRIDE

@stanleyyconsensys stanleyyconsensys requested a review from a team as a code owner October 17, 2024 09:27
@stanleyyconsensys stanleyyconsensys requested review from Julink-eth and wantedsystem and removed request for a team October 17, 2024 09:27
khanti42
khanti42 requested changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@khanti42 khanti42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit on comments

packages/starknet-snap/src/rpcs/get-deployment-data.ts Show resolved Hide resolved
packages/starknet-snap/src/rpcs/get-deployment-data.ts Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
2.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@stanleyyconsensys stanleyyconsensys added this pull request to the merge queue Oct 17, 2024
Merged via the queue into main with commit a034bcf Oct 17, 2024
13 checks passed
@stanleyyconsensys stanleyyconsensys deleted the feat/add-get-deployment-data-rpc branch October 17, 2024 10:10
@github-actions github-actions bot mentioned this pull request Oct 17, 2024
Merged
@stanleyyconsensys stanleyyconsensys changed the title feat: add RPC starkNet_getDeploymentData feat(Snap): add RPC starkNet_getDeploymentData Oct 17, 2024
This was referenced Nov 26, 2024
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khanti42 khanti42 khanti42 approved these changes

@Julink-eth Julink-eth Awaiting requested review from Julink-eth Julink-eth is a code owner automatically assigned from Consensys/snaps-factory-reviewers

@wantedsystem wantedsystem Awaiting requested review from wantedsystem wantedsystem is a code owner automatically assigned from Consensys/snaps-factory-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stanleyyconsensys @khanti42