-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Error): add error wrapper for wallet rpc error code #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanleyyconsensys
requested review from
Akaryatrh and
wantedsystem
and removed request for
a team
October 9, 2024 08:50
stanleyyconsensys
changed the title
chore(Error): add error wrapper
chore(Error): add error wrapper for wallet rpc error code
Oct 9, 2024
3 tasks
khanti42
reviewed
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit comment
Co-authored-by: khanti42 <[email protected]>
khanti42
approved these changes
Oct 9, 2024
Quality Gate passed for 'consensys_starknet-snap-wallet-ui'Issues Measures |
Quality Gate passed for 'consensys_starknet-snap-starknet-snap'Issues Measures |
Merged
This was referenced Nov 26, 2024
Closed
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add an error wrapper to integrate the error code from 'get-starknet' wallet rpc error
To avoid breaking any existing error format/type
we extends the current snap error and create a error wrapper
walletRpcError
by using thedata
field from theSnapError
ConstructorExample of an error object return to the Snap Consumer
for now we have implement above format into
BEGIN_COMMIT_OVERRIDE
feat: Add custom error code to meet get-starknet v4 exception format (#374)
END_COMMIT_OVERRIDE