Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow multiple consecutive transactions in estimateFee(Bulk) #289

Merged
merged 17 commits into from
Jul 31, 2024

Conversation

khanti42
Copy link
Collaborator

@khanti42 khanti42 commented Jul 11, 2024

Closes : #150

this PR fixes the gas fee estimation issue when a transaction is in the pending block.

image

@khanti42 khanti42 requested a review from a team as a code owner July 11, 2024 21:12
packages/starknet-snap/src/utils/starknetUtils.ts Outdated Show resolved Hide resolved
packages/starknet-snap/src/estimateFee.ts Outdated Show resolved Hide resolved
packages/starknet-snap/src/utils/starknetUtils.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you tell me again why we need use latest block on estimate fee , rather than pending? (default)

packages/starknet-snap/src/utils/starknetUtils.ts Outdated Show resolved Hide resolved
packages/starknet-snap/src/utils/starknetUtils.ts Outdated Show resolved Hide resolved
packages/starknet-snap/src/utils/starknetUtils.ts Outdated Show resolved Hide resolved
packages/starknet-snap/src/estimateFee.ts Outdated Show resolved Hide resolved
packages/starknet-snap/src/estimateFee.ts Outdated Show resolved Hide resolved
packages/starknet-snap/src/utils/starknetUtils.ts Outdated Show resolved Hide resolved
packages/starknet-snap/src/utils/starknetUtils.ts Outdated Show resolved Hide resolved
Copy link

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
33.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khanti42 khanti42 merged commit 5a501f9 into main Jul 31, 2024
13 checks passed
@khanti42 khanti42 deleted the fix/sf-656 branch July 31, 2024 21:01
@github-actions github-actions bot mentioned this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: Fail to sign multiple transactions consecutively
2 participants