Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: snap homepage error when state omit #218

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

stanleyyconsensys
Copy link
Collaborator

The PR is to fix the JSON RPC error when the snap new installed from other dapp instead of the default wallet UI

@stanleyyconsensys stanleyyconsensys requested a review from a team as a code owner March 21, 2024 02:46
Copy link

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@stanleyyconsensys stanleyyconsensys merged commit 41de2ea into main Mar 27, 2024
4 checks passed
@stanleyyconsensys stanleyyconsensys deleted the fix/snap-homepage-error-when-no-state-exist branch March 27, 2024 09:12
@github-actions github-actions bot mentioned this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants