Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New Apis for Snap #207

Merged
merged 5 commits into from
Mar 4, 2024
Merged

feat: New Apis for Snap #207

merged 5 commits into from
Mar 4, 2024

Conversation

mario-christopher
Copy link
Collaborator

Recreated PR after removing refs to get-starknet

@mario-christopher mario-christopher requested a review from a team as a code owner February 29, 2024 20:12
@mario-christopher mario-christopher changed the title New Apis for Snap feat: New Apis for Snap Feb 29, 2024
Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarqubecloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
31.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarqubecloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@stanleyyconsensys stanleyyconsensys merged commit 675647d into main Mar 4, 2024
4 checks passed
@stanleyyconsensys stanleyyconsensys deleted the newSnapApis branch March 4, 2024 05:03
@github-actions github-actions bot mentioned this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants